Spring RTS Engine

Someone in #main made me aware of a bug in either Spring or BA. It appeared to be BA.

The problem is that if you reclaim a feature with 0 metal and 0 energy, the feature will change to give NaN m/e (rez bot) or -2147483648 m/e (commander). During reclaiming the resource bar may also display an energy pull of -nan.

How to reproduce: Load therockjungle and reclaim some shrubs.

I suspect the bug is in here (LuaRules/Gadgets/unit_reclaim_fix.lua): Since there are no checks there for resource == 0 (or reclaimtime == 0).

true ! i had same and also on this map, i noticed it appears while making circle on own base uber annoying anyway

I'm pretty sure that's a feature. Those are NaN jungle shrubs of the tropical region of Northern England.

I wouldn't have expected AllowFeatureBuildStep to be called by the engine in this scenario since there is no build step to allow, however I'll fix this next rev.

still present in 7.14 (testing with spring RC), used the same map.

Yeah, this is why I always hated playing The Rock Jungle...

remove fucked trees which give -1 e/m ?

ARRRTTTTTTTURIIIIIIII

fixed version of LuaRules/Gadgets/unit_reclaim_fix.lua

the commander icons also still need fixing.
looks like most icons are now under LuaUI/Icons as PNG, and the commander ones are still under icons as TGA, and LuaUI/Widgets/unit_customicons.lua will need adjusting too.

is this related?
look at ressource bar. i was speccing a game when that happend, it only happend for a few seconds but numerous times. once with ebar too.