Spring RTS Engine

Why does disabling UI using F5 disable LuaUI drawscreen?

do i infer correctly this breaks Lua effects?

yes (actually not sure if all)

Which ones?
Commander nametags -> work
Display DPS -> works
LUPS -> works

Auswaschbar wrote:Which ones?
Commander nametags -> work
Display DPS -> works
LUPS -> works

Regret wrote:drawscreen

All those use drawworld etc afaik.

isn't drawworld the place you should be drawing effects, anyway?

edit: i've got a feeling that you actually want a different callin with a working name of DrawScreenUIHidden.

imbaczek wrote:isn't drawworld the place you should be drawing effects, anyway?

edit: i've got a feeling that you actually want a different callin with a working name of DrawScreenUIHidden.

No, there already is a check to see whether UI is disabled, I don't see the point to force drawscreen disabled.

Spring.IsGUIHidden

Regret wrote:

imbaczek wrote:isn't drawworld the place you should be drawing effects, anyway?

edit: i've got a feeling that you actually want a different callin with a working name of DrawScreenUIHidden.

No, there already is a check to see whether UI is disabled, I don't see the point to force drawscreen disabled.

WHy would someone call DrawScreen if screen drawing is disabled anyway?

Btw, you also fail to give any example widget...

Auswaschbar wrote:WHy would someone call DrawScreen if screen drawing is disabled anyway?

Btw, you also fail to give any example widget...

To change cursor size.

http://springrts.com/phpbb/viewtopic.php?f=23&t=19934

Regret wrote:No, there already is a check to see whether UI is disabled, I don't see the point to force drawscreen disabled.

1) clean separation of responsibility
2) backwards compatibility

imbaczek wrote:1) clean separation of responsibility
2) backwards compatibility

Drawscreen was always enabled. The disabling when UI is hidden was introduced only in recent spring versions. So what backwards compatibility are you talking about?

Also widget makers are responsible for checking whether UI is hidden with Spring.IsGUIHidden().

no idea, i didn't design the api nor do i follow changes in it; it's how i'd do it. if it was working differently than it is now, there should be a rationale somewhere.

imbaczek wrote:no idea, i didn't design the api nor do i follow changes in it; it's how i'd do it. if it was working differently than it is now, there should be a rationale somewhere.

What on earth is the Spring.IsGUIHidden for then? It was always used in drawscreen. There is no rational explanation for forcing drawscreen to be disabled other than catering to lazy widget makers that do not make the said check.

Spring.SetMouseCursor should be called from widget:Update anyway (see trepans SmoothScroll-widget).

Auswaschbar wrote:Spring.SetMouseCursor should be called from widget:Update anyway (see trepans SmoothScroll-widget).

It does not work in Update.

EDIT: seems there is widget:DrawScreenEffects() which makes this topic nil.