Offline chat support
Moderator: Moderators
Re: Offline chat support
Allow for organizational multi reciver private messages so that tourneys can spam away and also add a time of message decay..
->SayPrivate(ListOfRecivers, 1 day 48 h till decay)
->SayPrivate(ListOfRecivers, 1 day 48 h till decay)
Re: Offline chat support
Broadcast and time-scheduled messages seem interesting, but also out of scope of this proposal.
Is there a reason broadcast is needed? Can't multiple SayPrivate messages be sent normally?
Some sort of server-based event reporting feature wouldn't be bad - but that could probably be done as an upgrade of http://springrts.com/dl/LobbyProtocol/P ... AST:server
Is there a reason broadcast is needed? Can't multiple SayPrivate messages be sent normally?
Some sort of server-based event reporting feature wouldn't be bad - but that could probably be done as an upgrade of http://springrts.com/dl/LobbyProtocol/P ... AST:server
Re: Offline chat support
EventListener Architecture, to avoid continus request spamming - or server pumping useless info to everyone.
<- RegisterListener(Event)
->InformListenerOnEvent(Event, Listener)
<- RegisterListener(Event)
->InformListenerOnEvent(Event, Listener)
Re: Offline chat support
i've implemented it. known caveats:
- only registered channels can enable logging (=chanserv inside it)
- only channels with enabled logging can be subscribed to
- messages gets lost when user logins to server but doesn't join channel
- possible bugs i don't know yet
will apply soon on lobby server, will do some more local testing first. questions/thoughts?
- only registered channels can enable logging (=chanserv inside it)
- only channels with enabled logging can be subscribed to
- messages gets lost when user logins to server but doesn't join channel
- possible bugs i don't know yet
will apply soon on lobby server, will do some more local testing first. questions/thoughts?
Re: Offline chat support
A !command to manage this for clients without "o" compatibility flag would be nice.questions/thoughts?
E.g. for IRC bridge.
Re: Offline chat support
basicly its already backwards compatible and works without 'o' compatibility flag. you only need to subscribe once to the channels which can be done trough the irc bridge:
http://springrts.com/wiki/IrcBridge#How ... server_.3F
but then you won't see timestamps.
http://springrts.com/wiki/IrcBridge#How ... server_.3F
but then you won't see timestamps.
Re: Offline chat support
Assuming you implemented the unix time version, maybe we should use a standard way (as listed in my quote) of exchanging date and time instead?gajop wrote:Btw, are we sure it's best to use unixtime? Conversion seems annoying: http://www.epochconverter.com/
Is there no better date format than that, like this: http://en.wikipedia.org/wiki/ISO_8601 ?
What do you mean by this? Are messages not sent?abma wrote: - messages gets lost when user logins to server but doesn't join channel
I thought that your implementation would still send all messages, but do it regardless of whether or not user joined the channel.
Re: Offline chat support
atm ISO 8601 is used: https://github.com/spring/uberserver/bl ... l.py#L1583gajop wrote:Assuming you implemented the unix time version, maybe we should use a standard way (as listed in my quote) of exchanging date and time instead?
messages are only sent when you join a channel. when a user leaves server, before messages are sent / without joining the channel, messages are lost. this was easiest to implement / is most compatible / requires very few db writes.gajop wrote:What do you mean by this? Are messages not sent?
I thought that your implementation would still send all messages, but do it regardless of whether or not user joined the channel.
Re: Offline chat support
That all sounds OK imo.
Re: Offline chat support
Scandinavian letters don't work anymore in messages written in channel.
Re: Offline chat support
Has this been fixed? If not has the issue been reported in uber?Jools wrote:Scandinavian letters don't work anymore in messages written in channel.
Re: Offline chat support
should be fixed by this change:
https://github.com/spring/uberserver/co ... faadbeR644
(which is not applied yet)
https://github.com/spring/uberserver/co ... faadbeR644
(which is not applied yet)
Re: Offline chat support
applied. subscribe should work now...
or not fully... needs a bit more testing.
or not fully... needs a bit more testing.
Re: Offline chat support
ok, fixed one bug, should work now.
Re: Offline chat support
to subscribe to a channel, the client have to send this to the server
it will be interesting if i.e. irc bridge will be confused by it as now messages are send from users which are offline let's see.
atm this is only enabled for #sy, other channels have to enable storing history first. To subscribe in springlobby, write the above command in the main server window. with the irc-bridge, join &local and write it there.SUBSCRIBE chanName=sy
it will be interesting if i.e. irc bridge will be confused by it as now messages are send from users which are offline let's see.