CRNfix Engine Version: better replay performance
Moderator: Moderators
CRNfix Engine Version: better replay performance
The bug that has been causing a lot of late game stuttering issues, especially with many players and high CPU loads has been fixed.
The engine build 96.0.1-g382e626 CRNfix is just Spring 96.0 with this patch applied.
There are no other changes to the engine from 96.0, only 3 lines of code got changed.
All [ACE] autohosts already have this engine version as default, and I highly recommend playing large team games on servers which host this engine version.
Thanks to everyone!
The engine build 96.0.1-g382e626 CRNfix is just Spring 96.0 with this patch applied.
There are no other changes to the engine from 96.0, only 3 lines of code got changed.
All [ACE] autohosts already have this engine version as default, and I highly recommend playing large team games on servers which host this engine version.
Thanks to everyone!
Last edited by abma on 04 May 2014, 20:05, edited 1 time in total.
Reason: fix topic
Reason: fix topic
Re: CNRfix Engine Version: better late game performance
Much wubb to teh Beherith!
Re: CNRfix Engine Version: better late game performance
Caldari Navy Raven?
What was actually fixed?
What was actually fixed?
Re: CNRfix Engine Version: better late game performance
ClientReadNetgajop wrote:Caldari Navy Raven?
What was actually fixed?
http://springrts.com/mantis/view.php?id=4290
https://github.com/spring/spring/commit ... 898d839a0c
Re: CNRfix Engine Version: better late game performance
Going to test in about an hour.
Re: CNRfix Engine Version: better late game performance
Nice behe! Simple fix, however it's impressive how you managed to investigate the cause.
Re: CRNfix Engine Version: better late game performance
Haven't tested yet but good stuff, thanks behe. Anyone done any benchmarking yet?
Re: CRNfix Engine Version: better late game performance
woot, will this make it into 97?
Re: CRNfix Engine Version: better late game performance
My apologies to everyone involved, but it turns out I made a mistake while debugging, and this fix only affects stutter issues while watching replays
- Silentwings
- Posts: 3720
- Joined: 25 Oct 2008, 00:23
Re: CRNfix Engine Version: better late game performance
Meh, it happens Still a good catch.
Re: CRNfix Engine Version: better late game performance
IIRC aren't replays used in the comparisons of the violation and the spring engine? So it is possible this could rectify much of the bullshit frequently bantered around here.
Either way, it is a fix, I will happily take it behe! Does this effect the resume of a match when you have a crash/got booted or no idea if it would effect resuming a match?
Either way, it is a fix, I will happily take it behe! Does this effect the resume of a match when you have a crash/got booted or no idea if it would effect resuming a match?
Last edited by smoth on 27 Jan 2014, 23:49, edited 1 time in total.
Re: CRNfix Engine Version: better late game performance
I would guess.IIRC aren't replays used in the comparisons of the violation and the spring engine? So it is possible this could rectify much of the ignorant stuff frequently bantered around here.
However this just proves that replays shouldnt be used to test engine performance.
Behe its a fix and we will take it, no worries
Re: CRNfix Engine Version: better late game performance
I 100% agree scifi. That is NOT a good test but people were using it all the same.
- FabriceFABS
- Posts: 354
- Joined: 28 Jul 2010, 16:20
Re: CRNfix Engine Version: better late game performance
OK np, really !
-
- Posts: 843
- Joined: 13 Aug 2007, 13:19
Re: CRNfix Engine Version: better late game performance
Thx for trying behe!
Re: CRNfix Engine Version: better late game performance
Replays are useful for benchmarking if and only if they are correctly designed for the task and the engines being compared are similar enough.
Smoth: This CRNfix is nice but does not affect any benchmarking results. Stutter and simulation speed are not even related. I'd recommend you to be more careful in using the word ignorance around here.
Smoth: This CRNfix is nice but does not affect any benchmarking results. Stutter and simulation speed are not even related. I'd recommend you to be more careful in using the word ignorance around here.
Re: CRNfix Engine Version: better late game performance
ok. hang on while I edit my post.
Re: CRNfix Engine Version: better late game performance
Except that in this case it was relevant. Because each netmsg_synccheck forced an extra draw frame, thereby taking away time from doing sim frames.zer_ver wrote:Replays are useful for benchmarking if and only if they are correctly designed for the task and the engines being compared are similar enough.
Smoth: This CRNfix is nice but does not affect any benchmarking results. Stutter and simulation speed are not even related. I'd recommend you to be more careful in using the word ignorance around here.
Re: CRNfix Engine Version: better late game performance
Yeah, less than 2 fps per second, but it does not count as Sim time so none of my benchmarks would be affected. Also, MT engine would not gain anything from this fix.
- Forboding Angel
- Evolution RTS Developer
- Posts: 14673
- Joined: 17 Nov 2005, 02:43
Re: CRNfix Engine Version: better late game performance
Why don't you just release your source and stop this silly shit?