BA 7.78 Released!

[phi711]

I done all key combinaison you recommended and sometimes only with widget unit_reclaimer enabled but my nanos still don't reclaimed all my t1 solars.
If I selct one or some nanos, press e then hold alt and drag on a t1solar, nanos stay like blocked with a reclaim command on it, without reclaiming, like on this picture :

blocked nanos.png (345.7 KiB) Viewed 4052 times

It work if e key hold and dragged on same buildings is sended from one or some t1 constructors or from commander and if widget named "Specific Unit Reclaimer" is enabled. If I press alt key simultaneously this don't work.

Therefore, at the moment, this no multiple reclaim ability seems affect only nanos.

Otherwise I noticed nanos could accomplish the multi-reclaim job on Dragon's Teeth (Perimeter Defense).

[abma]

the effect that is spawned when a feature is reclaimed makes me spring lag for a short ammount of time. this doesn't happen with xta... (+ the effect looks slightly different)

imo this should be changed as it could cause performance bottlenecks.

[Silentwings]

Was that with 94.1.1-693 or plain 94.1?

[abma]

94.1.1-693 / current develop.

[knorke]

ba/xta gadgets are different.
xta one is basically just

Code: Select all

function gadget:FeatureDestroyed(featureID,allyteam)
  fx,fy,fz=Spring.GetFeaturePosition(featureID)
  Spring.SpawnCEG(mceg, fx, fy, fz)
end

and only spawns an effect once the feature is completly sucked away.

In BA there is a "metal flies to sky" effect constantly going on while the sucking is in progress.
So it uses GameFrame and AllowFeatureBuildStep.

Code: Select all

function gadget:GameFrame(n)
  for i,v in pairs(cegList) do
..
      cegList[i] = nil

deleting from table while iterating over it?

[abma]

it only lags after a feature is destroyed. while it is reclaimed i don't see an effect... maybe because of my gfx card not supporting feature x.

[knorke]

did you zoom in? it is very small effect of black stuff floating upwards.
It is just SpawnCEG dont think graphic cards can fail on that..
or maybe /maxparticles too low?

[abma]

maxparticles is set to 0... maybe a screenshots helps to find the cause. it lags, when the ceg is spawned.


edit: i guess this is it:
http://imolarpg.dyndns.org/trac/balates ... sh.lua#L24

(will try)

[knorke]

yes, similiar like that is in xta too.
but on top of that ba has
http://imolarpg.dyndns.org/trac/balates ... ds.lua#L45

[abma]

no, this doesn't cause the lag, i commented both of it out and the lag still exists when i reclaim a feature.

my fps drops from 60 fps (vsync limited) to 40 fps for maybe a second when a feature is reclaimed.

it lags with /luaui disabled & /luarules disabled on ba v7.78.
it doesn't lag with /luaui disabled & /luarules disabled in xta 9.729.

(-> it lags even without visible gfx effect)

ideas what the cause could be?

(that was the initial bug report: http://springrts.com/mantis/view.php?id=3867)

but i'm really confused, why it happens in BA but not XTA.

[Silentwings]

Ok, I've made a trac ticket and I'll work out what's causing it.

[Silentwings]

Therefore, at the moment, this no multiple reclaim ability seems affect only nanos.

Otherwise I noticed nanos could accomplish the multi-reclaim job on Dragon's Teeth (Perimeter Defense).

Hmm, it was meant to work for nanos too now, I'll check that. I guess it works for DT because those are essentially features.

edit: checked, for me it works fine with nanos.

[knorke]

well without luarules it must be engine thing then..
test if it happens when feature gets destroyed by other means than reclaim? crush or weapondamage, lua, resecurect,..
does it also happen for features that do not block pathing?

[abma]

well without luarules it must be engine thing then..

indeed it is. xta has much fewer units/movedevs, this is why it doesn't lag... sorry! (created a feature request: http://springrts.com/mantis/view.php?id=3867)

[Silentwings]

@abma, what did you mean by lag precisely? for me in 94.1.1-693 there is a tiny fps drop when a feature is reclaimed, but no more.

[abma]

fps drop from 60fps to 40fps for a very short time, but its an engine "bug", sorry.

[Silentwings]

No problem :)

[smoth]

fps drop from 60fps to 40fps for a very short time, but its an engine "bug", sorry.

any idea what is triggering it? Why it effects BA and nothing else?

[abma]

BA has more movedefs than xta...

[Beherith]

Because they are for freeeeeee! Which is also why it has so many units.