Offline chat support - Page 2

Offline chat support

For the discussion of infrastructure improvements and changes.

Moderator: Moderators

User avatar
PicassoCT
Journeywar Developer & Mapper
Posts: 10157
Joined: 24 Jan 2006, 21:12

Re: Offline chat support

Post by PicassoCT » 28 Jan 2015, 16:35

Allow for organizational multi reciver private messages so that tourneys can spam away and also add a time of message decay..


->SayPrivate(ListOfRecivers, 1 day 48 h till decay)
0 x

gajop
Moderator
Posts: 3015
Joined: 05 Aug 2009, 20:42

Re: Offline chat support

Post by gajop » 28 Jan 2015, 16:59

Broadcast and time-scheduled messages seem interesting, but also out of scope of this proposal.
Is there a reason broadcast is needed? Can't multiple SayPrivate messages be sent normally?

Some sort of server-based event reporting feature wouldn't be bad - but that could probably be done as an upgrade of http://springrts.com/dl/LobbyProtocol/P ... AST:server
0 x

User avatar
PicassoCT
Journeywar Developer & Mapper
Posts: 10157
Joined: 24 Jan 2006, 21:12

Re: Offline chat support

Post by PicassoCT » 28 Jan 2015, 17:26

EventListener Architecture, to avoid continus request spamming - or server pumping useless info to everyone.

<- RegisterListener(Event)

->InformListenerOnEvent(Event, Listener)
0 x

abma
Spring Developer
Posts: 3535
Joined: 01 Jun 2009, 00:08

Re: Offline chat support

Post by abma » 10 Feb 2015, 00:34

i've implemented it. known caveats:

- only registered channels can enable logging (=chanserv inside it)
- only channels with enabled logging can be subscribed to
- messages gets lost when user logins to server but doesn't join channel
- possible bugs i don't know yet

will apply soon on lobby server, will do some more local testing first. questions/thoughts?
0 x

User avatar
Anarchid
Posts: 1377
Joined: 30 Nov 2008, 04:31

Re: Offline chat support

Post by Anarchid » 10 Feb 2015, 01:33

questions/thoughts?
A !command to manage this for clients without "o" compatibility flag would be nice.

E.g. for IRC bridge.
0 x

abma
Spring Developer
Posts: 3535
Joined: 01 Jun 2009, 00:08

Re: Offline chat support

Post by abma » 10 Feb 2015, 01:48

basicly its already backwards compatible and works without 'o' compatibility flag. you only need to subscribe once to the channels which can be done trough the irc bridge:

http://springrts.com/wiki/IrcBridge#How ... server_.3F

but then you won't see timestamps.
0 x

gajop
Moderator
Posts: 3015
Joined: 05 Aug 2009, 20:42

Re: Offline chat support

Post by gajop » 10 Feb 2015, 03:12

gajop wrote:Btw, are we sure it's best to use unixtime? Conversion seems annoying: http://www.epochconverter.com/
Is there no better date format than that, like this: http://en.wikipedia.org/wiki/ISO_8601 ?
Assuming you implemented the unix time version, maybe we should use a standard way (as listed in my quote) of exchanging date and time instead?
abma wrote: - messages gets lost when user logins to server but doesn't join channel
What do you mean by this? Are messages not sent?
I thought that your implementation would still send all messages, but do it regardless of whether or not user joined the channel.
0 x

abma
Spring Developer
Posts: 3535
Joined: 01 Jun 2009, 00:08

Re: Offline chat support

Post by abma » 10 Feb 2015, 09:35

gajop wrote:Assuming you implemented the unix time version, maybe we should use a standard way (as listed in my quote) of exchanging date and time instead?
atm ISO 8601 is used: https://github.com/spring/uberserver/bl ... l.py#L1583

gajop wrote:What do you mean by this? Are messages not sent?
I thought that your implementation would still send all messages, but do it regardless of whether or not user joined the channel.
messages are only sent when you join a channel. when a user leaves server, before messages are sent / without joining the channel, messages are lost. this was easiest to implement / is most compatible / requires very few db writes.
0 x

gajop
Moderator
Posts: 3015
Joined: 05 Aug 2009, 20:42

Re: Offline chat support

Post by gajop » 10 Feb 2015, 10:16

That all sounds OK imo.
0 x

User avatar
Jools
XTA Developer
Posts: 2802
Joined: 23 Feb 2009, 16:29

Re: Offline chat support

Post by Jools » 10 Feb 2015, 12:57

Scandinavian letters don't work anymore in messages written in channel.
0 x

gajop
Moderator
Posts: 3015
Joined: 05 Aug 2009, 20:42

Re: Offline chat support

Post by gajop » 16 Feb 2015, 07:29

Jools wrote:Scandinavian letters don't work anymore in messages written in channel.
Has this been fixed? If not has the issue been reported in uber?
0 x

abma
Spring Developer
Posts: 3535
Joined: 01 Jun 2009, 00:08

Re: Offline chat support

Post by abma » 16 Feb 2015, 09:52

should be fixed by this change:

https://github.com/spring/uberserver/co ... faadbeR644

(which is not applied yet)
0 x

abma
Spring Developer
Posts: 3535
Joined: 01 Jun 2009, 00:08

Re: Offline chat support

Post by abma » 16 Feb 2015, 10:02

applied. subscribe should work now...

or not fully... needs a bit more testing.
0 x

abma
Spring Developer
Posts: 3535
Joined: 01 Jun 2009, 00:08

Re: Offline chat support

Post by abma » 16 Feb 2015, 11:10

ok, fixed one bug, should work now.
0 x

abma
Spring Developer
Posts: 3535
Joined: 01 Jun 2009, 00:08

Re: Offline chat support

Post by abma » 16 Feb 2015, 11:15

to subscribe to a channel, the client have to send this to the server
SUBSCRIBE chanName=sy
atm this is only enabled for #sy, other channels have to enable storing history first. To subscribe in springlobby, write the above command in the main server window. with the irc-bridge, join &local and write it there.

it will be interesting if i.e. irc bridge will be confused by it as now messages are send from users which are offline let's see.
0 x

Post Reply

Return to “Infrastructure Development”

cron