changed all repos to https in rapid

changed all repos to https in rapid

For the discussion of infrastructure improvements and changes.

Moderator: Moderators

Post Reply
abma
Spring Developer
Posts: 3757
Joined: 01 Jun 2009, 00:08

changed all repos to https in rapid

Post by abma »

all rapid repos where switched to https:

means all urls inside of https://repos.springrts.com/repos.gz are now https.

https://github.com/spring/pr-downloader ... 6caba1b4d2


https support for pr-downloader was introduced a long time ago, so hopefully nothing broke.
User avatar
Teifion
Posts: 18
Joined: 10 Mar 2021, 00:10

Re: changed all repos to https in rapid

Post by Teifion »

It appears to have caused an issue on Linux for BYAR-Chobby - https://discord.com/channels/5492816231 ... 9368226826.
ivand
Posts: 300
Joined: 27 Jun 2007, 17:05

Re: changed all repos to https in rapid

Post by ivand »

BYAR repo URL:

Code: Select all

ak@ak-virtual-machine /t/tmp.cCx1EUawd5 [8]> wget "https://repos.springrts.com/byar/streamer.cgi?03dcf63f881f646bf72bb05b581b8648"
--2021-09-19 23:45:02--  https://repos.springrts.com/byar/streamer.cgi?03dcf63f881f646bf72bb05b581b8648
Resolving repos.springrts.com (repos.springrts.com)... 78.46.21.29
Connecting to repos.springrts.com (repos.springrts.com)|78.46.21.29|:443... connected.
HTTP request sent, awaiting response... 500 Internal Server Error
2021-09-19 23:45:02 ERROR 500: Internal Server Error.


BYAR-Chobby repo URL

Code: Select all

ak@ak-virtual-machine /t/tmp.cCx1EUawd5 [8]> wget "https://repos.springrts.com/byar-chobby/streamer.cgi?49c4486b83a3d59f6b8f60897d27010f"
--2021-09-19 23:45:54--  https://repos.springrts.com/byar-chobby/streamer.cgi?49c4486b83a3d59f6b8f60897d27010f
Resolving repos.springrts.com (repos.springrts.com)... 78.46.21.29
Connecting to repos.springrts.com (repos.springrts.com)|78.46.21.29|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 936696 (915K)
Saving to: ‘streamer.cgi?49c4486b83a3d59f6b8f60897d27010f.1’

streamer.cgi?49c4486b83a3d59f6b8f60897d27010f.1                   100%[=============================================================================================================================================================>] 914,74K  2,37MB/s    in 0,4s

2021-09-19 23:45:55 (2,37 MB/s) - ‘streamer.cgi?49c4486b83a3d59f6b8f60897d27010f.1’ saved [936696/936696]
It downloads freaking binary file!
abma
Spring Developer
Posts: 3757
Joined: 01 Jun 2009, 00:08

Re: changed all repos to https in rapid

Post by abma »

for https the regex was wrong:

https://github.com/spring/pr-downloader ... e.conf#L18

the dash was missing: because of that, streamer.cgi wasn't executed for repos with a dash.


i've corrected the apache config by making that part an include and removed the duplicate config.


thanks for reporting!
ivand
Posts: 300
Joined: 27 Jun 2007, 17:05

Re: changed all repos to https in rapid

Post by ivand »

Thanks for the rapid fix!
abma
Spring Developer
Posts: 3757
Joined: 01 Jun 2009, 00:08

Re: changed all repos to https in rapid

Post by abma »

also added a test: https://github.com/spring/pr-downloader ... aa9a71a615

its not the first time this broke, sorry :-|
User avatar
IceXuick
Posts: 519
Joined: 14 Mar 2006, 01:46

Re: changed all repos to https in rapid

Post by IceXuick »

Thank you very much!
Post Reply

Return to “Infrastructure Development”