AllowSpectatorJoin set to true (default) makes autohosts insecure

AllowSpectatorJoin set to true (default) makes autohosts insecure

Discuss development of lobby clients, server, autohosts and auto-download software.

Moderators: Moderators, Lobby Developers

Post Reply
abma
Spring Developer
Posts: 3554
Joined: 01 Jun 2009, 00:08

AllowSpectatorJoin set to true (default) makes autohosts insecure

Post by abma » 10 Sep 2015, 16:16

@all autohosts admins:

please set AllowSpectatorJoin to false as it allows everyone to connect using any username which breaks permission checking of spads (and possible other stuff like stats on replays.springrts.com)

for some reason (which i don't really understand) its not wanted that the default value is changed to false:
https://github.com/spring/spring/commit ... dc016c85aa

this basicly applies to self-hosted games, too.

the default of AllowSpectatorJoin is true, so if you didn't change this value, your autohost is affected!

related bug reports:

https://springrts.com/mantis/view.php?id=3662
https://springrts.com/mantis/view.php?id=4949
0 x

abma
Spring Developer
Posts: 3554
Joined: 01 Jun 2009, 00:08

Re: AllowSpectatorJoin set to true (default) makes autohosts insecure

Post by abma » 10 Sep 2015, 20:19

Small update:

atm its not clear if spads implemented adding spectators correctly to a running game when spring is already running.
0 x

User avatar
bibim
Lobby Developer
Posts: 901
Joined: 06 Dec 2007, 11:12

Re: AllowSpectatorJoin set to true (default) makes autohosts insecure

Post by bibim » 10 Sep 2015, 21:18

What is unclear exactly?
0 x

abma
Spring Developer
Posts: 3554
Joined: 01 Jun 2009, 00:08

Re: AllowSpectatorJoin set to true (default) makes autohosts insecure

Post by abma » 11 Sep 2015, 00:54

bibim wrote:What is unclear exactly?
it was unclear for me if specs can join when AllowSpectatorJoin is set to false as i can't test it easily / or check if an autohost has AllowSpectatorJoin disabled.
0 x

User avatar
Silentwings
Moderator
Posts: 3590
Joined: 25 Oct 2008, 00:23

Re: AllowSpectatorJoin set to true (default) makes autohosts insecure

Post by Silentwings » 11 Sep 2015, 00:58

They can, the BlackHoleHosts have it disabled, and specs are able to join them midgame. The name of the tag is obviously misleading for autohost owners.
0 x

User avatar
FabriceFABS
Posts: 345
Joined: 28 Jul 2010, 16:20

Re: AllowSpectatorJoin set to true (default) makes autohosts insecure

Post by FabriceFABS » 11 Sep 2015, 02:48

abma wrote:@all autohosts admins...
Thank you Abma for posting the message right there and on Mantis regards this problem we've both talk yesterday.
Consequent to this, a fix will be surely made.

I got some ideas with logs and the replay, but I would like to know how if it's possible, with the replay to have IP extraction from the player that abusively connect with the [ACE]YopYop_BOT account.
0 x

Post Reply

Return to “Lobby Clients & Server”