Kernel Panic 4.6 - Page 2

Kernel Panic 4.6

Moderator: Content Developer

User avatar
zwzsg
Kernel Panic Co-Developer
Posts: 7031
Joined: 16 Nov 2004, 13:08

Re: Kernel Panic 4.6

Post by zwzsg »

abma
Spring Developer
Posts: 3655
Joined: 01 Jun 2009, 00:08

Re: Kernel Panic 4.6

Post by abma »

The lua gadget on the map "Hex Farm 7" seems to have an error. it calls Spring.SetMapSquareTerrainType() with an out of range index it seems. engine now gives an error when this function is called with invalid parameters.

see:
https://springrts.com/mantis/view.php?id=4714
https://github.com/spring/spring/commit ... 695c7950a1
User avatar
zwzsg
Kernel Panic Co-Developer
Posts: 7031
Joined: 16 Nov 2004, 13:08

Re: Kernel Panic 4.6

Post by zwzsg »

Thanks for the bug report.
abma on github wrote:whats prefered in such a case: silently accept invalid input or give an error message?
Since it used to be accepted silently, I would have preferred it to be changed to a warning or a silent clamping. Though, I kinda wonder, what used to happen when it was accepted, before it crashed the engine?
abma
Spring Developer
Posts: 3655
Joined: 01 Jun 2009, 00:08

Re: Kernel Panic 4.6

Post by abma »

zwzsg wrote:Since it used to be accepted silently, I would have preferred it to be changed to a warning or a silent clamping. Though, I kinda wonder, what used to happen when it was accepted, before it crashed the engine?
i guess sometimes it worked sometimes not. when i tested it, it crashed sometimes at start, sometimes at exit, sometimes it just hanged at exit.
Post Reply

Return to “Kernel Panic”