Page 1 of 1

[misc] upgrading to phpbb 3.3.1 aka the upgrade hell

Posted: 09 Sep 2020, 01:10
by abma
today i wanted to upgrade phpbb to the current version as it closes some security related issues.

I downloaded the update file and expanded it to the webserver. Then i opened the installer but it failed with "php 7.0 is not supported..."... fu..!

As the debian system which springrts.com runs is quiet old, i decided to upgrade it from version 9 (stretch) to version 10 (buster) so i could easily install php7.3, too:

edit /etc/apt/sources.list, replace "stretch" with "buster", run apt update && apt upgrade and wait a long time, answer some questions with "yes, please automatically restart the service", "yes, please overwrite the custom config file with the default version": done!

to finally update phpbb i had to install php7.3 and the required modules and restart apache.

then the update of phpbb finally worked, i logged in to the admin page and then:

syntax error in "phpbb/ext/anavaro/postlove/config/services.yml"...

shh...! i tried to fix it manually and: success it seems to work: https://github.com/spring/spring-websit ... 5c64fbf5d9

so, success!

as its to late i have to stop at this stage, but there possible is a lot of stuff left:

- manual data migration from postgresl 9.6 to postgres 11
- apt dist-upgrade
- restart services and see which one broke:
- buildbot master
- lobby server
- matrix servers + services
- rapid services: recompile pr-downloader / RapidTools used for repos.springrts.com
- wsgi services for replays.springrts.com
- mumble

and finally reboot server (up 673 days, 21:43)!

so, if you found some problem already, please post and i try to fix this asap!

thanks for reading! :-)

Re: [misc] upgrading to phpbb 3.3.1 aka the upgrade hell

Posted: 09 Sep 2020, 09:48
by abma
sadly the phpBB extension postlove seems not compatible to phpBB any more: i had disabled it.

Re: [misc] upgrading to phpbb 3.3.1 aka the upgrade hell

Posted: 09 Sep 2020, 17:57
by FLOZi
Upgrading phpbb is a nightmare indeed. tbh I think this is true for all bb software.

Re: [misc] upgrading to phpbb 3.3.1 aka the upgrade hell

Posted: 10 Sep 2020, 04:49
by MasterBel
Hey, thanks for the upgrade but also it would be really nice if we have warning for things like this. ATM, suddenly something breaks, then we all try to work out how to fix it, until it comes back online and "Btw that was all planned, you can stop panicking now".

TLDR; please give us at least vague warning of when upgrades like this are gonna happen

Re: [misc] upgrading to phpbb 3.3.1 aka the upgrade hell

Posted: 10 Sep 2020, 05:36
by Silentwings
- restart services and see which one broke:
- lobby server
Seems OK, systemctl restart worked. (Also, lobbyserver uptime was 112 days, longest for a long while.)

Re: [misc] upgrading to phpbb 3.3.1 aka the upgrade hell

Posted: 10 Sep 2020, 22:47
by abma
MasterBel wrote: 10 Sep 2020, 04:49 Hey, thanks for the upgrade but also it would be really nice if we have warning for things like this. ATM, suddenly something breaks, then we all try to work out how to fix it, until it comes back online and "Btw that was all planned, you can stop panicking now".

TLDR; please give us at least vague warning of when upgrades like this are gonna happen
What suddenly broke in this case? Theoretically only the website wasn't available for a short time which shouldn't lead to panic mode. All other stuff should have happened after this post.

Its really difficult to do such huge changes with the few time i have. I want to do stuff, not to write about stuff i maybe will do.

Also there is no possibility to contact all persons before such changes. Where should i inform all people? It would be sth. like "in two weeks there will be an update", but thats sadly not possible when you administrate stuff in your spare time with a full time job.

Re: [misc] upgrading to phpbb 3.3.1 aka the upgrade hell

Posted: 10 Sep 2020, 22:55
by abma
Silentwings wrote: 10 Sep 2020, 05:36
- restart services and see which one broke:
- lobby server
Seems OK, systemctl restart worked. (Also, lobbyserver uptime was 112 days, longest for a long while.)
Nice + good work! 8)

Re: [misc] upgrading to phpbb 3.3.1 aka the upgrade hell

Posted: 12 Sep 2020, 03:32
by MasterBel
abma wrote: 10 Sep 2020, 22:47 Its really difficult to do such huge changes with the few time i have. I want to do stuff, not to write about stuff i maybe will do.
I'm thinking of something simple like "Sometime in the next month, I'm hoping to run an upgrade. If the server goes down, it's probably that. It should be up within a few hours of going down."

I don't mean to cause an inconvenience (but rather solve them), so whatever you feel most practical would be appreciated.

Re: [misc] upgrading to phpbb 3.3.1 aka the upgrade hell

Posted: 12 Sep 2020, 07:15
by raaar
although I understand Abma's point of view: time and willpower is limited and spending time explaining things and convincing others can be draining...I agree with Masterbel that there should be at least some kind of early warning.

It's been a recurring issue on the past year that changes broke important stuff like downloads, the ability of new players to get registered easily, or the replays site.

Springfiles still has broken image references after the changes it went through.

Re: [misc] upgrading to phpbb 3.3.1 aka the upgrade hell

Posted: 13 Sep 2020, 15:37
by ThinkSome
I think that Abma should find a successor for himself or at least someone who can do all that he can do, because this is not sustainable.

Re: [misc] upgrading to phpbb 3.3.1 aka the upgrade hell

Posted: 13 Sep 2020, 16:00
by Silentwings
I suggest less thought about warning notifications and more thought about bus factors - which imo are dangerously low for the engine & its supporting infra. Sadly it's unreasonable to expect abma to "find" a successor for himself & also unlikely that any single person could manage so much stuff without at least a year or two of PRs/working themselves up to it. Harsh reality of dependencies: when time/numbers are short its down to the people who use the stuff to step in & learn some new stuff - or suffer the breakages.

Re: [misc] upgrading to phpbb 3.3.1 aka the upgrade hell

Posted: 14 Sep 2020, 12:26
by abma
ThinkSome wrote: 13 Sep 2020, 15:37 I think that Abma should find a successor for himself or at least someone who can do all that he can do, because this is not sustainable.
viewtopic.php?f=38&t=33804

Re: [misc] upgrading to phpbb 3.3.1 aka the upgrade hell

Posted: 17 Sep 2020, 20:55
by abma
viewtopic.php?t=41886

"reboot of springrts.com server tomorrow, Fri Sep. 18. 2020 at 10:30 GMT+2"

Re: [misc] upgrading to phpbb 3.3.1 aka the upgrade hell

Posted: 18 Sep 2020, 00:24
by gajop
abma wrote: 14 Sep 2020, 12:26
ThinkSome wrote: 13 Sep 2020, 15:37 I think that Abma should find a successor for himself or at least someone who can do all that he can do, because this is not sustainable.
viewtopic.php?f=38&t=33804
Can you provide some links to where the springfiles server code is? (both frontend and backend)

In particular I'm looking for whatever repository is in charge of things like:
1) registering and logging into springfiles accounts
2) backend for downloading rapid content via pr-downloader
3) backend for downloading engines, and if separate, the system that marks the appropriate OS for engine builds.

So far I think upq might be related to some of these parts but I don't think it's the full story.

Re: [misc] upgrading to phpbb 3.3.1 aka the upgrade hell

Posted: 18 Sep 2020, 06:50
by abma
gajop wrote: 18 Sep 2020, 00:24 1) registering and logging into springfiles accounts
thats drupal 6 :? there is no code to show
gajop wrote: 18 Sep 2020, 00:24 2) backend for downloading rapid content via pr-downloader
basicly https://github.com/springfiles/upq/blob ... pidsync.py
gajop wrote: 18 Sep 2020, 00:24 3) backend for downloading engines, and if separate, the system that marks the appropriate OS for engine builds.
https://github.com/springfiles/upq/blob ... onfetch.py
+ https://github.com/spring/spring/blob/d ... t/list.php


i started to heavily simplify the code, but the "big purge" didn't start yet: https://github.com/springfiles/upq/blob ... sf_sync.py


when you want to continue on this, create some upload page, which checks lobby auth and calls download_and_add_file() with the uploaded file. the next step should be some nicer frontend for http://api.springfiles.com/ IMHO, a simple example exists: http://api.springfiles.com/newindex.html