spring engine binaries and debug symbols as a github release

spring engine binaries and debug symbols as a github release

Discuss the source code and development of Spring Engine in general from a technical point of view. Patches go here too.

Moderator: Moderators

Post Reply
ivand
Posts: 310
Joined: 27 Jun 2007, 17:05

spring engine binaries and debug symbols as a github release

Post by ivand »

Can someone with the access upload binaries and debug symbols as a github release?
User avatar
Silentwings
Posts: 3720
Joined: 25 Oct 2008, 00:23

Re: Spring 105.0 released: maintenance release

Post by Silentwings »

+1 on releasing this and finally calling time on maintainance.

Re github release, I've never actually tested it but Github claims to block pushes with >100Mb content https://docs.github.com/en/free-pro-tea ... arge-files. The debug symbols are 150Mb for each OS release, so I think no!
ivand
Posts: 310
Joined: 27 Jun 2007, 17:05

Re: Spring 105.0 released: maintenance release

Post by ivand »

Silentwings wrote: 01 Jan 2021, 20:46 +1 on releasing this and finally calling time on maintainance.

Re github release, I've never actually tested it but Github claims to block pushes with >100Mb content https://docs.github.com/en/free-pro-tea ... arge-files. The debug symbols are 150Mb for each OS release, so I think no!
It's regarding storing large files in the repo. Github releases have no such limitations. See: https://github.com/beyond-all-reason/sp ... 4-g321b911
abma
Spring Developer
Posts: 3798
Joined: 01 Jun 2009, 00:08

Re: spring engine binaries and debug symbols as a github release

Post by abma »

(split topic)

the source code from https://github.com/beyond-all-reason/sp ... 21b911.zip doesn't contain the git submodules: this very likely makes it impossible to compile that source package. If i remember right, there have been several reports about this with older spring releases, thats one of the reasons why you don't easily find links to github.
Can someone with the access upload binaries and debug symbols as a github release?
can this zip files be removed? this answers your question i guess...


the release checklist IMHO is way to long: https://github.com/spring/spring/blob/d ... cklist.txt

anything which makes it longer should be avoided. what does manual uploading the files to github improve?
ivand
Posts: 310
Joined: 27 Jun 2007, 17:05

Re: spring engine binaries and debug symbols as a github release

Post by ivand »

abma wrote: 01 Jan 2021, 22:11 the source code from https://github.com/beyond-all-reason/sp ... 21b911.zip doesn't contain the git submodules: this very likely makes it impossible to compile that source package.
It's added by github automatically every time a release or pre-release is made. In any case I feel with DVCS like git storing sources in zip is redundant. Github does it on its own, I don't mind, but if I ever need to go back in time I'll do git checkout with submodules. If you still feel like storing sources with all submodules, they can be added as yet another release artifact.
abma wrote: 01 Jan 2021, 22:11 can this zip files be removed? this answers your question i guess...
If you mean zip files with source code, then no, you cannot. The rest can be added / removed by any user with access rights. Even by a github action worker, like in case of BAR branch.
abma wrote: 01 Jan 2021, 22:11 what does manual uploading the files to github improve?
It's a reliable URL, that will never get deleted unless you want so.
User avatar
Forboding Angel
Evolution RTS Developer
Posts: 14673
Joined: 17 Nov 2005, 02:43

Why not have a github action to upload builds to github?

Post by Forboding Angel »

This seems like the easiest solution? That way github can be referenced for downloading past engine builds. Maybe I'm overlooking a critical issue with doing it this way?
ivand
Posts: 310
Joined: 27 Jun 2007, 17:05

Re: Why not have a github action to upload builds to github?

Post by ivand »

This was discussed just a few topics below: viewtopic.php?p=596427#p596427

Merged. (Silentwings)
Post Reply

Return to “Engine”