Removing SM3 support

Removing SM3 support

Discuss the source code and development of Spring Engine in general from a technical point of view. Patches go here too.

Moderator: Moderators

Post Reply
hokomoko
Spring Developer
Posts: 593
Joined: 02 Jun 2014, 00:46

Removing SM3 support

Post by hokomoko »

I think it is time.
RFC
gajop
Moderator
Posts: 3051
Joined: 05 Aug 2009, 20:42

Re: Removing SM3 support

Post by gajop »

Sounds good!

hijack: Any plan for future work on the map format or should we make custom map shaders? Can we start making them or should we wait for engine changes?
User avatar
Jools
XTA Developer
Posts: 2816
Joined: 23 Feb 2009, 16:29

Re: Removing SM3 support

Post by Jools »

Needs more information, for instance:
- what is sm3
- why was it implemented
- why do we want it removed
- what will replace it
Kloot
Spring Developer
Posts: 1867
Joined: 08 Oct 2006, 16:58

Re: Removing SM3 support

Post by Kloot »

SM3 *support* was already removed long ago.

viewtopic.php?p=546048#p546048 is the reason the code still exists.
hokomoko
Spring Developer
Posts: 593
Joined: 02 Jun 2014, 00:46

Re: Removing SM3 support

Post by hokomoko »

hmm, well, problem solved I guess.
I think the historical reference isn't important anymore, especially as we keep making commits affecting it whenever some wide change is done:
https://github.com/spring/spring/commit ... ts/Map/SM3
I'll remove it unless there are relevant objections.
User avatar
Jools
XTA Developer
Posts: 2816
Joined: 23 Feb 2009, 16:29

Re: Removing SM3 support

Post by Jools »

Just comment out all SM3 .cpp's in rts/Map/CMakeLists.txt, leave the code for historical reference.

Do this.
gajop
Moderator
Posts: 3051
Joined: 05 Aug 2009, 20:42

Re: Removing SM3 support

Post by gajop »

We use Git so history will always be there. Do we have any benefit by keeping actual code? Seems like it would only confuse new devs.
sprunk
Posts: 100
Joined: 29 Jun 2015, 07:36

Re: Removing SM3 support

Post by sprunk »

I support removal.
User avatar
Jools
XTA Developer
Posts: 2816
Joined: 23 Feb 2009, 16:29

Re: Removing SM3 support

Post by Jools »

If it confuses new developers then they are not ready to become develops. What benefits are there in wasting time for something like this?
User avatar
Silentwings
Posts: 3720
Joined: 25 Oct 2008, 00:23

Re: Removing SM3 support

Post by Silentwings »

+1 for removal & archiving.
hokomoko
Spring Developer
Posts: 593
Joined: 02 Jun 2014, 00:46

Re: Removing SM3 support

Post by hokomoko »

User avatar
PicassoCT
Journeywar Developer & Mapper
Posts: 10450
Joined: 24 Jan 2006, 21:12

Re: Removing SM3 support

Post by PicassoCT »

Jools wrote:Just comment out all SM3 .cpp's in rts/Map/CMakeLists.txt, leave the code for historical reference.

Do this.
Eh, there are tags for this, and its Git-embalmed? So no need to have dead source around?
Post Reply

Return to “Engine”