I think it is time.
RFC
Removing SM3 support
Moderator: Moderators
Re: Removing SM3 support
Sounds good!
hijack: Any plan for future work on the map format or should we make custom map shaders? Can we start making them or should we wait for engine changes?
hijack: Any plan for future work on the map format or should we make custom map shaders? Can we start making them or should we wait for engine changes?
Re: Removing SM3 support
Needs more information, for instance:
- what is sm3
- why was it implemented
- why do we want it removed
- what will replace it
- what is sm3
- why was it implemented
- why do we want it removed
- what will replace it
Re: Removing SM3 support
SM3 *support* was already removed long ago.
viewtopic.php?p=546048#p546048 is the reason the code still exists.
viewtopic.php?p=546048#p546048 is the reason the code still exists.
Re: Removing SM3 support
hmm, well, problem solved I guess.
I think the historical reference isn't important anymore, especially as we keep making commits affecting it whenever some wide change is done:
https://github.com/spring/spring/commit ... ts/Map/SM3
I'll remove it unless there are relevant objections.
I think the historical reference isn't important anymore, especially as we keep making commits affecting it whenever some wide change is done:
https://github.com/spring/spring/commit ... ts/Map/SM3
I'll remove it unless there are relevant objections.
Re: Removing SM3 support
Just comment out all SM3 .cpp's in rts/Map/CMakeLists.txt, leave the code for historical reference.
Do this.
Do this.
Re: Removing SM3 support
We use Git so history will always be there. Do we have any benefit by keeping actual code? Seems like it would only confuse new devs.
Re: Removing SM3 support
If it confuses new developers then they are not ready to become develops. What benefits are there in wasting time for something like this?
- Silentwings
- Posts: 3720
- Joined: 25 Oct 2008, 00:23
Re: Removing SM3 support
+1 for removal & archiving.
Re: Removing SM3 support
Eh, there are tags for this, and its Git-embalmed? So no need to have dead source around?Jools wrote:Just comment out all SM3 .cpp's in rts/Map/CMakeLists.txt, leave the code for historical reference.
Do this.