comments over changes on sourcecode

comments over changes on sourcecode

Discuss the source code and development of Spring Engine in general from a technical point of view. Patches go here too.

Moderator: Moderators

Post Reply
User avatar
MelKor
Posts: 38
Joined: 15 Oct 2010, 16:05

comments over changes on sourcecode

Post by MelKor » 08 Nov 2018, 19:00

Hi guys,

I'm watching the changes of the code in GitHub, the cleaning/update of the code you are doing is a great job, looks good, follow standards, etc..., however, pick my attention the use (and maybe abuse) of the 'auto' specifier. I mention that because I constantly read code with it on my job and for people not familiarized with the code (or not so proficiency on C++) take a lot more of brain cycles to understand it, and even more if you have to find some bug or make proper updates, I know that it looks good on the screen, but...

Is just a comment, try to not an abuse of that specifier, could make life harder on future, even for yourself.

Have a great day !!

MK
1 x

gajop
Moderator
Posts: 2984
Joined: 05 Aug 2009, 20:42

Re: comments over changes on sourcecode

Post by gajop » 08 Nov 2018, 23:59

Give specifics examples that you didn't like.
I did express the type explicitly when I thought that'd be helpful.
PS: also try to comment on GitHub PRs/commits. I'd appreciate any kind of code review.
1 x

User avatar
PicassoCT
Journeywar Developer & Mapper
Posts: 9964
Joined: 24 Jan 2006, 21:12

Re: comments over changes on sourcecode

Post by PicassoCT » 09 Nov 2018, 12:00

PS: also try to comment on GitHub PRs/commits. I'd appreciate any kind of code review.


That sentence right there, that is a mistake. But i gladly take you up on that offer.
1 x

Post Reply

Return to “Engine”