PhpBB 3.1 - Page 2

PhpBB 3.1

Various things about Spring that do not fit in any of the other forums listed below, including forum rules.

Moderator: Moderators

User avatar
Tim Blokdijk
Posts: 1242
Joined: 29 May 2005, 11:18

Re: PhpBB 3.1

Post by Tim Blokdijk »

As for the patch jK pointed to.
The captcha patch does a little div background trick that can't be applied 1on1 to 3.1, it should work fine without it.
PhpBB 3.1 has the utf_normalizer static thing included.

That leaves the custom smilies that needs to be checked.
Also FLOZi's remark that MediaWiki uses the PhpBB user logins.. need to check if that's still working.
Fix css for links.
And update README.updatephpbb and create a new SPRING.patch

@Forboding Angel
Ehh, yea. I do need 3.1 and your theme seems to be based on 3.0 ..
According to this topic the creator is not going to update Artodia Deluxe to 3.1 but he might release a new similar style.
I'm fine with anything that is properly compatible with prosilver.
Prosilver is also responsive btw, the Spring layout with its fixed width breaks it..
User avatar
Forboding Angel
Evolution RTS Developer
Posts: 14673
Joined: 17 Nov 2005, 02:43

Re: PhpBB 3.1

Post by Forboding Angel »

Sorry to rain on your parade, but no it isn't.

Image

My theme was responsive down to 320px (iphone 4 screen) and very nicely so.

Unfortunately you say that it cannot be applied? Why is that? Has enough layout things changed in phpbb that 3.0 themes won't work on 3.1?

If so, it's a testament to the shittiness of phpbb theme framework (The only theme framework I have seen that is more pathetic than phpbb is mediawiki).

Hell, I partially wrote the theme framework for MyUPB 10 years ago and it was significantly better than this crap, and that code SUCKED (actually, for 10 years ago it was about as advanced as you could get at the time... there weren't a whole lot of ways to do nice themes).

In that case, I suggest using a fully responsive theme (I don't care where it comes from and who gives a shit if the forum theme matches the site... Really). It's 2015 people... Some of us like to use our phones to browse forums and not have to constantly be double tap zooming and pinching and crap.

The site is already pretty pathetic. A mismatching theme honestly is pretty par for the course.
User avatar
Tim Blokdijk
Posts: 1242
Joined: 29 May 2005, 11:18

Re: PhpBB 3.1

Post by Tim Blokdijk »

If I disable the "spring" theme and use prosilver without our layout and visit the test forum (ff, nexus5) it's responsive. Add in the spring layout and it's the site we all love to hate, I don't know what css/html in the spring site is responsible.
Forboding Angel wrote:Unfortunately you say that it cannot be applied? Why is that? Has enough layout things changed in phpbb that 3.0 themes won't work on 3.1?
There are significant changes, 3.0 themes won't work or break badly at best. It would take multiple days of full-time work, if not weeks.
Forboding Angel wrote:In that case, I suggest using a fully responsive theme (I don't care where it comes from and who gives a shit if the forum theme matches the site... Really).
Yes.. I agree. It's not the problem I'm out to solve but I would drop the footer and have a simple logo and menu at the top (that's responsive). You do want to preserve the navigation.
User avatar
Forboding Angel
Evolution RTS Developer
Posts: 14673
Joined: 17 Nov 2005, 02:43

Re: PhpBB 3.1

Post by Forboding Angel »

Calling 3.1 prosilver "responsive" is a stretch and rather generous... But whatever, it's better than the BS that we have now.
User avatar
Tim Blokdijk
Posts: 1242
Joined: 29 May 2005, 11:18

Re: PhpBB 3.1

Post by Tim Blokdijk »

I'm a generous guy. :-)

But let me be clear that I'm not going to do layout work, it's not the problem I'm out to solve. I agree with you that it's very much needed but it's "patches welcome".
I hope to fix up the last things this Sunday, then we can take it live and I can continue with writing my PhpBB 3.1 extension. I need to keep my focus on that.
User avatar
Forboding Angel
Evolution RTS Developer
Posts: 14673
Joined: 17 Nov 2005, 02:43

Re: PhpBB 3.1

Post by Forboding Angel »

Yeah once it goes live and is on git and all that crap, if I run into some free time I'll clone it and see if there's anything useful I can do with it.
User avatar
Tim Blokdijk
Posts: 1242
Joined: 29 May 2005, 11:18

Re: PhpBB 3.1

Post by Tim Blokdijk »

Custom smilies should just work.
And MediaWiki using the PhpBB user logins works to.. but I'm not familiar with that hack.

[edit]
That leaves:
Fix css for links.
And update README.updatephpbb and create a new SPRING.patch


Done!
As far as I can tell it can be put live. Last chance to check things @ http://test.springrts.com
Pull request @ https://github.com/spring/spring-website/pull/20
[/edit]
abma
Spring Developer
Posts: 3798
Joined: 01 Jun 2009, 00:08

Re: PhpBB 3.1

Post by abma »

done!
User avatar
FLOZi
MC: Legacy & Spring 1944 Developer
Posts: 6240
Joined: 29 Apr 2005, 01:14

Re: PhpBB 3.1

Post by FLOZi »

Agh, so many years, my brain refuses to accept it! :shock:

Any chance of avatars being put back on the correct side?
abma
Spring Developer
Posts: 3798
Joined: 01 Jun 2009, 00:08

Re: PhpBB 3.1

Post by abma »

only major issue i currently see is that .css files and .js files don't get cached. any clue how to fix that?

its a huge (!!!) waste of bandwith. apache would fix this, but imo there should be an phpbb setting?!


edit: fixed, added mod_expires rules to apache config. also i've changed filename of stylesheets, this forces a reload of the css.
User avatar
qray
Posts: 377
Joined: 02 Feb 2009, 18:49

Re: PhpBB 3.1

Post by qray »

FLOZi wrote:Agh, so many years, my brain refuses to accept it! :shock:
Any chance of avatars being put back on the correct side?
Full ACK, my brain is confused, too :-)
Somehow, apart from all the mentioned short-comings: I miss the old layout :wink:
But if I get it right, a new layout is coming (sooner or later)?

Nevertheless: Thanks for updating!
User avatar
zwzsg
Kernel Panic Co-Developer
Posts: 7049
Joined: 16 Nov 2004, 13:08

Re: PhpBB 3.1

Post by zwzsg »

I miss the "see all recent posts" button.
gajop
Moderator
Posts: 3051
Joined: 05 Aug 2009, 20:42

Re: PhpBB 3.1

Post by gajop »

User avatar
Anarchid
Posts: 1384
Joined: 30 Nov 2008, 04:31

Re: PhpBB 3.1

Post by Anarchid »

^ is not a button.
User avatar
zwzsg
Kernel Panic Co-Developer
Posts: 7049
Joined: 16 Nov 2004, 13:08

Re: PhpBB 3.1

Post by zwzsg »

Yes, it's not an easily accessible button, and it doesn't even work without logging in.
gajop
Moderator
Posts: 3051
Joined: 05 Aug 2009, 20:42

Re: PhpBB 3.1

Post by gajop »

It's one more click.
"Active topics" also has the similar functionality and works without logging in.
User avatar
Tim Blokdijk
Posts: 1242
Joined: 29 May 2005, 11:18

Re: PhpBB 3.1

Post by Tim Blokdijk »

FLOZi wrote:Any chance of avatars being put back on the correct side?
Prosilver has it on the right by default, it's not a choice I made. Still during development I did get used to it being on the right.
By now I think it should be on the right as I (reading from left to right) want to read the post text and do not care that much about the avatars, but I might be biased as I don't have one..
Anyway, changing things might be good for creativity, give it a few days, I got used to it.

All the other criticism including those from viewtopic.php?f=21&t=33313 I agree with. More or less.
  1. Patch it
  2. Create a pull request
  3. Test it on test.springrts.com
  4. Let everybody debate whether it "looks nice"
  5. Put it live anyhow :wink:
qray wrote:Nevertheless: Thanks for updating!
Thanks. :-)
User avatar
Forboding Angel
Evolution RTS Developer
Posts: 14673
Joined: 17 Nov 2005, 02:43

Re: PhpBB 3.1

Post by Forboding Angel »

I like it on the right.

It has been commonplace for sidebars on websites to be on the right for a long time now. Considering that the avatar panel is essentially a sidebar, it makes logical sense for it to be on the right.
gajop
Moderator
Posts: 3051
Joined: 05 Aug 2009, 20:42

Re: PhpBB 3.1

Post by gajop »

Put it back on the left. We're used to it.
I'm also not sure what sites you frequent, but those that I do all have it on the left.
In fact looking at the popular social networks:
- Facebook, Twitter, Youtube, Google+, etc.
and semi-related sites:
- ZK, 0AD, github, arch linux
all have it on the left.

And further, in most languages, it's just really common in to have:
[[ Person ]]: TEXT, and not
TEXT [[ Person ]]

I am all up for upgrading, but this is a change no one asked for!
User avatar
Forboding Angel
Evolution RTS Developer
Posts: 14673
Joined: 17 Nov 2005, 02:43

Re: PhpBB 3.1

Post by Forboding Angel »

gajop wrote:Put it back on the left. We're used to it.
I'm also not sure what sites you frequent, but those that I do all have it on the left.
In fact looking at the popular social networks:
- Facebook, Twitter, Youtube, Google+, etc.
and semi-related sites:
- ZK, 0AD, github, arch linux
all have it on the left.

And further, in most languages, it's just really common in to have:
[[ Person ]]: TEXT, and not
TEXT [[ Person ]]

I am all up for upgrading, but this is a change no one asked for!
Image

ZK and 0AD are terrible examples as both sites are so amateur it hurts.

For the sake of it...

Image

Image

Arch linux? Really?

Image

All your examples have right hand sidebars...

Facebook has sidebars on the left and the right.

Google+ doesn't have a sidebar, it has a menu that drops in on the left and hangouts which takes up the entire right.

Youtube is similar

Image

Drop down menu on left. Drop down menus are always on the left, as they should be. Sidebars are generally on the right.

Now, lets look at some truly professional sites:

Image

Image

Image

The point here is... Sidebar on the right is accepted norm. In fact, sidebar on the left is seen by many designers as amateurish. The idea being content comes first. Sidebar content is less important than main content, therefore it comes last.

Suck it up. It won't kill you to get used to something new.


I am tired of people complaining about shit simply because it's new.

Image
Post Reply

Return to “General Discussion”