| View Issue Details [ Jump to Notes ] [ Related Changesets ] | [ Issue History ] [ Print ] | ||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||
|---|---|---|---|---|---|---|---|---|---|
| 0006408 | Spring engine | Lua | public | 2020-07-19 00:18 | 2020-07-19 19:27 | ||||
| Reporter | sprung | ||||||||
| Assigned To | Kloot | ||||||||
| Priority | low | Severity | minor | Reproducibility | always | ||||
| Status | resolved | Resolution | fixed | ||||||
| Product Version | 104.0 +git | ||||||||
| Target Version | Fixed in Version | 104.0 +git | |||||||
| Summary | 0006408: VFS.FileExists seems to use wrong mode when loading defs | ||||||||
| Description | During the defs loading phase, VFS.FileExists("foo", nil, VFS.MAP) returns true even when the file only exists gameside. | ||||||||
| Steps To Reproduce | See the attached zip, it has a minimal reproduction mod and script (any map without unitdefs_posts should work). My output: [f=-000001] [LoadScreen::SetLoadMessage] text="Loading GameData Definitions" [f=-000001] isInMap (should usually be false), true [f=-000001] the FileExists was most likely a lie, Include() file missing 'gamedata/unitdefs_post.lua' [f=-000001] [defs.lua] Error: Failed to load unitDefs | ||||||||
| Tags | No tags attached. | ||||||||
| Checked infolog.txt for Errors | Yes | ||||||||
| Attached Files |
| ||||||||
 Relationships |
|
 Relationships |
| Notes |
|
|
Kloot (developer) 2020-07-19 09:26 |
VFS.FileExists takes two arguments, not three. if the second is nil the VFS_ZIP mode gets used by default. |
|
Anonymous (viewer) 2020-07-19 19:25 |
Fix 1e55cf28c3b8ca0c77c49da864a720bf778774e3 committed to develop branch: fix 0006408, repo: spring changeset id: 37932 |
|
Anonymous (viewer) 2020-07-19 19:25 |
Fix fdd9ca6aa7b70409e1649ae4bebee082692356dc committed to maintenance branch: fix 0006408, repo: spring changeset id: 37933 |
|
Anonymous (viewer) 2020-07-19 19:25 |
Fix 5588635e042731acdca74b72356e3c7d05e3a2b3 committed to transition branch: fix 0006408, repo: spring changeset id: 37934 |
| Notes |
| Related Changesets |
|||
|
spring: transition 5588635e
Timestamp: 2020-07-19 19:23:42 Author: rtri [ Details ] [ Diff ] |
fix 0006408 | ||
| mod - rts/Lua/LuaParser.cpp | [ Diff ] [ File ] | ||
| mod - rts/Lua/LuaVFS.cpp | [ Diff ] [ File ] | ||
|
spring: maintenance fdd9ca6a
Timestamp: 2020-07-19 19:24:12 Author: rtri [ Details ] [ Diff ] |
fix 0006408 | ||
| mod - rts/Lua/LuaParser.cpp | [ Diff ] [ File ] | ||
| mod - rts/Lua/LuaVFS.cpp | [ Diff ] [ File ] | ||
|
spring: develop 1e55cf28
Timestamp: 2020-07-19 19:24:22 Author: rtri [ Details ] [ Diff ] |
fix 0006408 | ||
| mod - rts/Lua/LuaParser.cpp | [ Diff ] [ File ] | ||
| mod - rts/Lua/LuaVFS.cpp | [ Diff ] [ File ] | ||
| Related Changesets |
| Issue History |
|||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2020-07-19 00:18 | sprung | New Issue | |
| 2020-07-19 00:18 | sprung | File Added: VFS.SDD.zip | |
| 2020-07-19 09:26 | Kloot | Note Added: 0020472 | |
| 2020-07-19 19:25 | Changeset attached | => spring develop 1e55cf28 | |
| 2020-07-19 19:25 | Anonymous | Note Added: 0020473 | |
| 2020-07-19 19:25 | Changeset attached | => spring maintenance fdd9ca6a | |
| 2020-07-19 19:25 | Anonymous | Note Added: 0020474 | |
| 2020-07-19 19:25 | Changeset attached | => spring transition 5588635e | |
| 2020-07-19 19:25 | Anonymous | Note Added: 0020475 | |
| 2020-07-19 19:27 | Kloot | Assigned To | => Kloot |
| 2020-07-19 19:27 | Kloot | Status | new => resolved |
| 2020-07-19 19:27 | Kloot | Resolution | open => fixed |
| 2020-07-19 19:27 | Kloot | Fixed in Version | => 104.0 +git |
| Issue History |