| View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 0006217 | Spring engine | General | public | 2019-05-04 21:51 | 2019-05-05 12:28 | ||||||||
| Reporter | silentwings | ||||||||||||
| Assigned To | |||||||||||||
| Priority | normal | Severity | major | Reproducibility | always | ||||||||
| Status | new | Resolution | open | ||||||||||
| Product Version | 104.0 +git | ||||||||||||
| Target Version | Fixed in Version | ||||||||||||
| Summary | 0006217: luaui entry point check fails to search inside basecontent | ||||||||||||
| Description | LuaUI entry point should detect when luaui.lua is present within base content, as the luaui entry point, but currently it fails to do so. The basecontent file exists in https://github.com/spring/spring/tree/develop/cont Afaics currently this check doesn't work correctly (i.e. VFS_BASE is not checked): https://github.com/spring/spring/blob/863bc7441aad1dd839b36d28de8ce4d62c961469/rts/Lua/LuaUI.cpp#L87 Infologs from raar: http://paste.springfiles.com/view/ef3b06a2 (detects luaui.lua) http://paste.springfiles.com/view/0cd4db97 (fails to detect luaui.lua) | ||||||||||||
| Tags | No tags attached. | ||||||||||||
| Checked infolog.txt for Errors | Yes | ||||||||||||
| Attached Files |
| ||||||||||||
 Relationships |
|
 Relationships |
| Notes |
|
|
raaar (reporter) 2019-05-04 21:54 |
the pastebins expire within a month, i've uploaded the infologs here as well |
|
hokomoko (developer) 2019-05-04 22:13 |
luaui entry point is not in base, it's in raw |
|
silentwings (reporter) 2019-05-04 22:18 |
[21:11:41] <Nightwatch> <ashdnazg#5048> luaui entry point is not in base [21:12:42] <Nightwatch> <ashdnazg#5048> https://i.imgur.com/omvCM2m.png [21:12:54] <Nightwatch> <ashdnazg#5048> it's in raw [21:14:10] <[Fx]Bluestone> in which VFS_MOD won't detect it? [21:16:25] <Nightwatch> <ashdnazg#5048> indeed |
|
hokomoko (developer) 2019-05-04 22:25 |
I think all luaui stuff should move into base content, RFC |
|
silentwings (reporter) 2019-05-04 22:38 |
+1 |
|
Kloot (developer) 2019-05-05 11:56 |
+0.5, I have some concerns about LuaUI discoverability. |
|
hokomoko (developer) 2019-05-05 12:28 |
I thought about this, it raises a tad bit the threshold of going into luadev, but let's be rel, no one can really just jump into widget deving. The API is monstrous, you need the wiki open in all times and if you're working on an existing game, you have to know its shenanigans as well. |
| Notes |
| Issue History |
|||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2019-05-04 21:51 | silentwings | New Issue | |
| 2019-05-04 21:53 | raaar | File Added: infolog_743_widgets_load.txt | |
| 2019-05-04 21:53 | raaar | File Added: infolog_853_widgets_dont_load.txt | |
| 2019-05-04 21:54 | raaar | Note Added: 0019975 | |
| 2019-05-04 22:13 | hokomoko | Note Added: 0019976 | |
| 2019-05-04 22:18 | silentwings | Note Added: 0019977 | |
| 2019-05-04 22:25 | hokomoko | Note Added: 0019978 | |
| 2019-05-04 22:38 | silentwings | Note Added: 0019979 | |
| 2019-05-05 11:56 | Kloot | Note Added: 0019981 | |
| 2019-05-05 12:28 | hokomoko | Note Added: 0019982 | |
| Issue History |