| View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||
|---|---|---|---|---|---|---|---|---|---|
| 0006005 | Spring engine | General | public | 2018-06-17 01:05 | 2018-06-21 21:03 | ||||
| Reporter | adridg | ||||||||
| Assigned To | abma | ||||||||
| Priority | normal | Severity | minor | Reproducibility | always | ||||
| Status | resolved | Resolution | fixed | ||||||
| Product Version | 104.0 +git | ||||||||
| Target Version | Fixed in Version | ||||||||
| Summary | 0006005: CMake 3.12 heads up: changes in file(GLOB) | ||||||||
| Description | Starting with CMake 3.12, `file(GLOB ... FOLLOW_SYMLINKS ...)` is an error. The `file()` command was never documented to use *FOLLOW_SYMLINKS*, but it ignored the keyword. In 3.12 (rc1 was just released, and while testing FreeBSD package builds with that new version we hit this problem in spring), this causes an error. | ||||||||
| Steps To Reproduce | Use CMake 3.12-rc1 to try to build spring. The error is: ``` CMake Error at rts/build/cmake/Util.cmake:168 (File): File FOLLOW_SYMLINKS is not a valid parameter for GLOB. ``` | ||||||||
| Additional Information | The problematic CMake code is in two places: ``` spring/rts/build/cmake/UtilJava.cmake: file(GLOB dirContent RELATIVE "${dir}" FOLLOW_SYMLINKS "${dir}/*") spring/rts/build/cmake/Util.cmake: File(GLOB ${list_var} RELATIVE "${CMAKE_CURRENT_SOURCE_DIR}" FOLLOW_SYMLINKS "${CMAKE_CURRENT_SOURCE_DIR}/*/CMakeLists.txt") ``` In both cases, just drop *FOLLOW_SYMLINKS* or, if you meant to glob recursively, switch to *GLOB_RECURSE* which is used elsewhere in the same CMake modules. | ||||||||
| Tags | No tags attached. | ||||||||
| Checked infolog.txt for Errors | |||||||||
| Attached Files |
| ||||||||
 Relationships |
|
 Relationships |
| Notes |
|
|
abma (administrator) 2018-06-19 10:36 |
Fix 219be4a46b3a8c795a0bee011d2148bb5bf8d387 committed to develop branch: fix 0006005: cmake 3.12 error, repo: spring changeset id: 10356 |
|
abma (administrator) 2018-06-21 21:03 |
Fix 4784a350a4246d80db6fc66f6dcfa514eddc3f40 committed to maintenance branch: fix 0006005: cmake 3.12 error, repo: spring changeset id: 10360 |
| Notes |
| Issue History |
|||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2018-06-17 01:05 | adridg | New Issue | |
| 2018-06-19 10:36 | abma | Changeset attached | => spring develop 219be4a4 |
| 2018-06-19 10:36 | abma | Note Added: 0019215 | |
| 2018-06-19 10:36 | abma | Assigned To | => abma |
| 2018-06-19 10:36 | abma | Status | new => resolved |
| 2018-06-19 10:36 | abma | Resolution | open => fixed |
| 2018-06-21 21:03 | Kloot | Changeset attached | => spring maintenance 4784a350 |
| 2018-06-21 21:03 | abma | Note Added: 0019216 | |
| Issue History |