| View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||
|---|---|---|---|---|---|---|---|---|---|
| 0005156 | Spring engine | General | public | 2016-03-09 01:40 | 2016-03-10 01:12 | ||||
| Reporter | abma | ||||||||
| Assigned To | abma | ||||||||
| Priority | normal | Severity | minor | Reproducibility | have not tried | ||||
| Status | resolved | Resolution | fixed | ||||||
| Product Version | |||||||||
| Target Version | 102.0 | Fixed in Version | |||||||
| Summary | 0005156: can ModUICtrl be removed as it seems unused?! | ||||||||
| Description | the only place where it is used is for spring-headless to claim more speed (?) atm it makes it more difficult to write tests as Spring.SendCommands() doesn't work with spring-headless. | ||||||||
| Additional Information | any point of allowing to disable LuaModUICtrl? the speed gain should be minor as luaui very likely is already disabled in headless if not, can it be removed? | ||||||||
| Tags | No tags attached. | ||||||||
| Checked infolog.txt for Errors | |||||||||
| Attached Files |
| ||||||||
 Relationships |
|
 Relationships |
| Notes |
|
|
hokomoko (developer) 2016-03-09 11:23 |
luaui isn't disabled in headless |
|
abma (administrator) 2016-03-09 13:55 |
hmm, ok, i guess i meant "hideinterface" then: https://github.com/spring/spring/blob/develop/cont/examples/Widgets/headless_setup.lua#L28 still, is there a point of keeping ModUICtrl? |
|
Kloot (developer) 2016-03-09 14:04 Last edited: 2016-03-09 14:07 |
it blocks user (non-mod) widgets from doing potentially unwanted actions, like extracting files or messing with the mod's UI. also: CONFIG(bool, LuaModUICtrl).defaultValue(true).headlessValue(false); |
|
abma (administrator) 2016-03-09 15:45 |
> it blocks user (non-mod) widgets from doing potentially unwanted actions, like extracting files or messing with the mod's UI. then the config setting can be removed at least and changing at runtime will be kept?! doesn't look like its used anywhere: https://github.com/search?l=lua&p=1&q=GetModUICtrl&ref=searchresults&type=Code&utf8=%E2%9C%93 |
|
abma (administrator) 2016-03-10 01:12 |
Fix 2581dc9ba37d8a9cb27253a544d16e2fcd0ea79a committed to develop branch: remove LuaModUICtrl config setting: fix 0005156, repo: spring changeset id: 6812 |
| Notes |
| Issue History |
|||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2016-03-09 01:40 | abma | New Issue | |
| 2016-03-09 01:42 | abma | Description Updated | View Revisions |
| 2016-03-09 01:42 | abma | Additional Information Updated | View Revisions |
| 2016-03-09 11:23 | hokomoko | Note Added: 0016025 | |
| 2016-03-09 13:55 | abma | Note Added: 0016026 | |
| 2016-03-09 14:04 | Kloot | Note Added: 0016027 | |
| 2016-03-09 14:07 | Kloot | Note Edited: 0016027 | View Revisions |
| 2016-03-09 15:45 | abma | Note Added: 0016028 | |
| 2016-03-10 01:12 | abma | Changeset attached | => spring develop 2581dc9b |
| 2016-03-10 01:12 | abma | Note Added: 0016037 | |
| 2016-03-10 01:12 | abma | Assigned To | => abma |
| 2016-03-10 01:12 | abma | Status | new => resolved |
| 2016-03-10 01:12 | abma | Resolution | open => fixed |
| Issue History |