2019-09-15 18:39 CEST

View Issue Details Jump to Notes ] Related Changesets ]
IDProjectCategoryView StatusLast Update
0004840Spring engineBuildbotpublic2015-06-27 10:55
Reporterabma 
Assigned Tocleanrock 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusresolvedResolutionfixed 
Product Version 
Target VersionFixed in Version 
Summary0004840: debug build doesn't compile / buildbot seems to use release build
Descriptionhttp://buildbot.springrts.com/builders/validationtests/builds/4726/steps/validation%20test%20install/logs/stdio

->
 99.0.1-15-g3ddffd4 develop ()

debug missing?
TagsNo tags attached.
Checked infolog.txt for lua Errors
Attached Files

-Relationships
+Relationships

-Notes

~0014709

abma (administrator)

https://github.com/spring/spring/commit/92857b59414acb857fa0bb5a93d90a864a921c03

~0014711

abma (administrator)

buildbot seems to be debugbuild. i can successfully compile a debug build local, too.

thats weird, this can only happen when you create a debug build and DEBUG_BUILD=FALSE is set.

can you please check if CMakeCache.txt contains DEBUG_BUILD and if so, remove that line?

~0014721

cleanrock (developer)

I don't have DEBUG_BUILD in my CMakeCache.txt.

abma, did you try a fresh debug build ? I.e. CMAKE_BUILD_TYPE=Debug in a empty directory.

The problem is that both _DEBUG and ASSIMP_BUILD_NO_VALIDATEDS_PROCESS are defined, this will compile the code in ApplyPostProcessing but the header is not included.

This issue has been fixed upstream: https://github.com/assimp/assimp/commit/4e7b59b

[ 23%] Building CXX object rts/lib/assimp/code/CMakeFiles/assimp.dir/Importer.cpp.o
cd /home/johanr/my_projects/spring_build/build_develop_debug/rts/lib/assimp/code && /usr/bin/c++ -DASSIMP_BUILD_DLL_EXPORT -DASSIMP_BUILD_NO_3D_IMPORTER -DASSIMP_BUILD_NO_AC_IMPORTER -DASSIMP_BUILD_NO_ASE_IMPORTER -DASSIMP_BUILD_NO_B3D_IMPORTER -DASSIMP_BUILD_NO_BVH_IMPORTER -DASSIMP_BUILD_NO_COB_IMPORTER -DASSIMP_BUILD_NO_CSM_IMPORTER -DASSIMP_BUILD_NO_DXF_IMPORTER -DASSIMP_BUILD_NO_HMP_IMPORTER -DASSIMP_BUILD_NO_IFC_IMPORTER -DASSIMP_BUILD_NO_IRRMESH_IMPORTER -DASSIMP_BUILD_NO_IRR_IMPORTER -DASSIMP_BUILD_NO_LWS_IMPORTER -DASSIMP_BUILD_NO_M3_IMPORTER -DASSIMP_BUILD_NO_MD2_IMPORTER -DASSIMP_BUILD_NO_MD3_IMPORTER -DASSIMP_BUILD_NO_MD5_IMPORTER -DASSIMP_BUILD_NO_MDC_IMPORTER -DASSIMP_BUILD_NO_MDL_IMPORTER -DASSIMP_BUILD_NO_MS3D_IMPORTER -DASSIMP_BUILD_NO_NDO_IMPORTER -DASSIMP_BUILD_NO_NFF_IMPORTER -DASSIMP_BUILD_NO_OBJ_IMPORTER -DASSIMP_BUILD_NO_OFF_IMPORTER -DASSIMP_BUILD_NO_OGRE_IMPORTER -DASSIMP_BUILD_NO_OWN_ZLIB -DASSIMP_BUILD_NO_PLY_IMPORTER -DASSIMP_BUILD_NO_Q3BSP_IMPORTER -DASSIMP_BUILD_NO_Q3D_IMPORTER -DASSIMP_BUILD_NO_RAW_IMPORTER -DASSIMP_BUILD_NO_SMD_IMPORTER -DASSIMP_BUILD_NO_STL_IMPORTER -DASSIMP_BUILD_NO_TERRAGEN_IMPORTER -DASSIMP_BUILD_NO_VALIDATEDS_PROCESS -DASSIMP_BUILD_NO_XGL_IMPORTER -DASSIMP_BUILD_NO_X_IMPORTER -DBOOST_NO_FENV_H -DSPRING_DATADIR=\"/home/johanr/spring_develop_debug/share/games/spring\" -DSTREFLOP_SSE -DSYNCCHECK -DTHREADPOOL -DUSE_LIBSQUISH -DUSE_VALGRIND -D_GLIBCXX_USE_NANOSLEEP -D_RANDOM_TCC -fuse-ld=gold -std=gnu++11 -fdiagnostics-color=always -mtune=generic -msse -mfpmath=sse -mno-sse2 -mno-sse3 -mno-ssse3 -mno-sse4.1 -mno-sse4.2 -mno-sse4 -mno-sse4a -mno-avx -mno-fma -mno-fma4 -mno-xop -mno-lwp -mno-avx2 -frounding-math -mieee-fp -pipe -fno-strict-aliasing -fvisibility=hidden -fvisibility-inlines-hidden -pthread -O0 -Wall -Wno-sign-compare -Wno-unknown-pragmas -DDEBUG -D_DEBUG -DNO_CATCH_EXCEPTIONS -ggdb -I/home/johanr/my_projects/spring/rts -I/home/johanr/my_projects/spring/rts/lib/minizip -o CMakeFiles/assimp.dir/Importer.cpp.o -c /home/johanr/my_projects/spring/rts/lib/assimp/code/Importer.cpp
/home/johanr/my_projects/spring/rts/lib/assimp/code/Importer.cpp: In member function ‘const aiScene* Assimp::Importer::ApplyPostProcessing(unsigned int)’:
/home/johanr/my_projects/spring/rts/lib/assimp/code/Importer.cpp:796:4: error: ‘ValidateDSProcess’ was not declared in this scope
    ValidateDSProcess ds;
    ^
/home/johanr/my_projects/spring/rts/lib/assimp/code/Importer.cpp:797:4: error: ‘ds’ was not declared in this scope
    ds.ExecuteOnScene (this);
    ^
rts/lib/assimp/code/CMakeFiles/assimp.dir/build.make:238: recipe for target 'rts/lib/assimp/code/CMakeFiles/assimp.dir/Importer.cpp.o' failed

~0014722

cleanrock (developer)

If it works for you i guess that DEBUG_BUILD is set when you build for debug, do you set this manually ?
I think it should be possible to build with only CMAKE_BUILD_TYPE=Debug.

~0014724

cleanrock (developer)

Found the problem, Debug don't cut it, this is case-sensitive:
# set some internal vars
If ("${CMAKE_BUILD_TYPE}" MATCHES "^DEBUG")
    Set(DEBUG_BUILD TRUE)

~0014725

cleanrock (developer)

Fix 11dee4e238f5041ae640e9dddca17c0335a84892 committed to develop branch: use case-insensitive match when setting DEBUG_BUILD

fixes 0004840, repo: spring changeset id: 5257
+Notes

+Related Changesets

-Issue History
Date Modified Username Field Change
2015-06-26 10:39 abma New Issue
2015-06-26 10:40 abma Note Added: 0014709
2015-06-26 16:31 abma Assigned To => abma
2015-06-26 16:31 abma Status new => assigned
2015-06-26 19:14 abma Note Added: 0014711
2015-06-26 19:14 abma Assigned To abma => cleanrock
2015-06-26 19:14 abma Status assigned => feedback
2015-06-27 09:38 cleanrock Note Added: 0014721
2015-06-27 09:57 cleanrock Note Added: 0014722
2015-06-27 10:27 cleanrock Note Added: 0014724
2015-06-27 10:55 cleanrock Changeset attached => spring develop 11dee4e2
2015-06-27 10:55 cleanrock Note Added: 0014725
2015-06-27 10:55 cleanrock Status feedback => resolved
2015-06-27 10:55 cleanrock Resolution open => fixed
+Issue History