2019-05-19 15:19 CEST

View Issue Details Jump to Notes ]
IDProjectCategoryView StatusLast Update
0004479Spring engineLuapublic2019-03-18 19:06
ReporterGoogle_Frog 
Assigned ToKloot 
PrioritylowSeverityfeatureReproducibilityN/A
StatusresolvedResolutionfixed 
Product Version97.0.1+git 
Target VersionFixed in Version104.0 +git 
Summary0004479: Let Script.SetWatchWeapon pick callins
DescriptionThe wiki says that Script.SetWatchWeapon is required for Explosion, ProjectileCreated and ProjectileDestroyed but my testing says it is also required for AllowWeaponTarget and AllowWeaponTargetCheck. It seems like a waste of performance to watch all of these callins when I just want to watch one of them. So if there is performance to be gained from not watching everything it would be nice if Script.SetWatchWeapon were extended to let me choose which callins I want to watch.
TagsNo tags attached.
Checked infolog.txt for lua Errors
Attached Files

-Relationships
+Relationships

-Notes

~0019871

Google_Frog (reporter)

Can this be looked into? I am seeing a lot of time spent in Sim::Weapon (16% at times) and think that some of this could be due to unnecessary lua calls related to weapons. I watch most weapons for AllowWeaponTarget but in most cases don't want to watch the other callins. AllowWeaponTargetID==-1 could also be made into a separate callin and added to this request.

~0019872

Google_Frog (reporter)

If the request is fine, but it is just a lot of tedious work, I could try to fix my compiling and make a PR.

~0019878

Kloot (developer)

1102-g8639730 allows replacing SetWatchWeapon by SetWatchExplosion / SetWatchProjectile / SetWatchAllowTarget.
+Notes

-Issue History
Date Modified Username Field Change
2014-07-30 13:28 Google_Frog New Issue
2019-03-18 00:06 Google_Frog Note Added: 0019871
2019-03-18 00:07 Google_Frog Note Added: 0019872
2019-03-18 00:42 Kloot Assigned To => Kloot
2019-03-18 00:42 Kloot Status new => assigned
2019-03-18 19:06 Kloot Status assigned => resolved
2019-03-18 19:06 Kloot Resolution open => fixed
2019-03-18 19:06 Kloot Fixed in Version => 104.0 +git
2019-03-18 19:06 Kloot Note Added: 0019878
+Issue History