removal of AllowUnsafeChanges("USE AT YOUR OWN PERIL")
Moderator: Moderators
removal of AllowUnsafeChanges("USE AT YOUR OWN PERIL")
Engine devs agreed that there aren't 'unsafe' changes and if there are than they are engine bugs.
So I would like to remove that function in the next Spring RC.
Opinion by modders welcome, if this is too short dated and you already fixed your mods with current git.
So I would like to remove that function in the next Spring RC.
Opinion by modders welcome, if this is too short dated and you already fixed your mods with current git.
Re: removal of AllowUnsafeChanges("USE AT YOUR OWN PERIL")
Bin it.
This RC would be preferable as mods are already forced to update for it (modinfo.tdf and startUnit changes).
This RC would be preferable as mods are already forced to update for it (modinfo.tdf and startUnit changes).
-
- Moderator
- Posts: 2464
- Joined: 12 Oct 2007, 09:24
Re: removal of AllowUnsafeChanges("USE AT YOUR OWN PERIL")
I agree. Errors from unsafe changes are engine bugs so there is no point calling them unsafe changes.
- TheFatController
- Balanced Annihilation Developer
- Posts: 1177
- Joined: 10 Dec 2006, 18:46
Re: removal of AllowUnsafeChanges("USE AT YOUR OWN PERIL")
This is not clear, do you mean that AllowUnsafeChanges("USE AT YOUR OWN PERIL") will always be on or do you mean that you want to remove the ability to give orders outside of gameframe and so on?jK wrote:Engine devs agreed that there aren't 'unsafe' changes and if there are than they are engine bugs.
So I would like to remove that function in the next Spring RC.
Opinion by modders welcome, if this is too short dated and you already fixed your mods with current git.
Re: removal of AllowUnsafeChanges("USE AT YOUR OWN PERIL")
He means it will always be on. No loss of functionality, just dispensing with the chore of flipping the switch.
Re: removal of AllowUnsafeChanges("USE AT YOUR OWN PERIL")
`Unsafe` changes will be always allowed and the AllowUnsafeChanges() function will get removed (any tries to call it will give an error).
Re: removal of AllowUnsafeChanges("USE AT YOUR OWN PERIL")
What's the word on this?
- BrainDamage
- Lobby Developer
- Posts: 1164
- Joined: 25 Sep 2006, 13:56
Re: removal of AllowUnsafeChanges("USE AT YOUR OWN PERIL")
since this is a quite important change, mod-breaking even, may I suggest creating another sticky in the mod section like for the other compatibility-breaking changes?
also, given the short notice ( other changes had 6 months+ warning, and were delayed by 1 major release too ) I think it would be better than instead of removing the function completely, to add an empty stub in the engine that prints a deprecation warning, and remove the stub in the next major release.
also, given the short notice ( other changes had 6 months+ warning, and were delayed by 1 major release too ) I think it would be better than instead of removing the function completely, to add an empty stub in the engine that prints a deprecation warning, and remove the stub in the next major release.
Re: removal of AllowUnsafeChanges("USE AT YOUR OWN PERIL")
Then again, if it's at the same time as removing modinfo.tdf support..
- BrainDamage
- Lobby Developer
- Posts: 1164
- Joined: 25 Sep 2006, 13:56
Re: removal of AllowUnsafeChanges("USE AT YOUR OWN PERIL")
the 2 proposals are distinct, while you can bring the "break all at once" argument for the second point, there's no reason not to advertise the change properly like the others were
Re: removal of AllowUnsafeChanges("USE AT YOUR OWN PERIL")
Code: Select all
if AllowUnsafeChanges then AllowUnsafeChanges("USE AT YOUR OWN PERIL") end
Indeed it should be advertised though.
Re: removal of AllowUnsafeChanges("USE AT YOUR OWN PERIL")
I agree with that, deprecation warnings given out by the engine are probably the best way to communicate with the developer. No need to break things more than necessary.BrainDamage wrote:also, given the short notice ( other changes had 6 months+ warning, and were delayed by 1 major release too ) I think it would be better than instead of removing the function completely, to add an empty stub in the engine that prints a deprecation warning, and remove the stub in the next major release.
Re: removal of AllowUnsafeChanges("USE AT YOUR OWN PERIL")
announcementified
Re: removal of AllowUnsafeChanges("USE AT YOUR OWN PERIL")
Is this announcement still relevant? It's been almost a year since the change.
Re: removal of AllowUnsafeChanges("USE AT YOUR OWN PERIL")
Apparently, yes:
azert123 wrote:Code: Select all
[f=0000000] Loading LuaRules [f=0000000] Lua LoadCode pcall error = 2, LuaRules/main.lua, [string "LuaRules/main.lua"]:1: attempt to call global 'AllowUnsafeChanges' (a nil value)
Re: removal of AllowUnsafeChanges("USE AT YOUR OWN PERIL")
That's an outdated game without a maintainer/developer.zwzsg wrote:Apparently, yes:
azert123 wrote:Code: Select all
[f=0000000] Loading LuaRules [f=0000000] Lua LoadCode pcall error = 2, LuaRules/main.lua, [string "LuaRules/main.lua"]:1: attempt to call global 'AllowUnsafeChanges' (a nil value)
Re: removal of AllowUnsafeChanges("USE AT YOUR OWN PERIL")
moving to archive.
I think the place where most people got in contact with AllowUnsafeChanges was the old game_spawn.lua but now it has been updated since a while:
https://github.com/spring/spring/blob/m ... _spawn.lua
I think the place where most people got in contact with AllowUnsafeChanges was the old game_spawn.lua but now it has been updated since a while:
https://github.com/spring/spring/blob/m ... _spawn.lua
Re: removal of AllowUnsafeChanges("USE AT YOUR OWN PERIL")
this was five years ago.
if still want to document then do it on https://springrts.com/wiki/EngineChange ... ontentDevs or add AllowUnsafeChanges() to Lua wiki and mark it as deprecated.
if still want to document then do it on https://springrts.com/wiki/EngineChange ... ontentDevs or add AllowUnsafeChanges() to Lua wiki and mark it as deprecated.