default widget put your building in wait when you E-stall

default widget put your building in wait when you E-stall

Classic game design, maintained to please you...

Moderator: Content Developer

Post Reply
User avatar
albator
Posts: 866
Joined: 14 Jan 2009, 14:20

default widget put your building in wait when you E-stall

Post by albator »

Anyone know the name of that widget ? so I can finally disable it
All my building/unit go on wait when I E-stall and never go back to normal.

I need to reclaim factory cause there is no unwait button. I have been looking for the widget doing that forever and I cannot find it. Since it is quite an unexpected and hard behavior to reproduce. it mostly happen in ffa. When you I am typically with +5kE prod, -10kE drain. Maybe that is a magic number problem somewhere in one of the widget.

I have NO additional widget, just the default BA's
I am using ubuntu 12.04 x64
User avatar
jamerlan
Balanced Annihilation Developer
Posts: 683
Joined: 20 Oct 2009, 13:04

Re: default widget put your building in wait when you E-stall

Post by jamerlan »

LOL.
This is "D-gun unstall" widget.

But you can "unwait" your factory using "wait" button in orders menu (take a look at attached screenshot).

P.S. TY for bug report. I enabled and tested this widget. So this widget set my labs on "wait" too and even after dgun, factory are still on "wait".
Attachments
screen00037.png
(1.71 MiB) Downloaded 3 times
User avatar
albator
Posts: 866
Joined: 14 Jan 2009, 14:20

Re: default widget put your building in wait when you E-stall

Post by albator »

Do you mean the widget activates even you DO NOT Dgun ?
User avatar
jamerlan
Balanced Annihilation Developer
Posts: 683
Joined: 20 Oct 2009, 13:04

Re: default widget put your building in wait when you E-stall

Post by jamerlan »

albator wrote:Do you mean the widget activates even you DO NOT Dgun ?
No, looks like this widget has bug. It not removes "wait" command from factories after I use d-gun. Even if I deselect my commander - factories are still on wait.

I tested it under Fedora 17 linux)
User avatar
very_bad_soldier
Posts: 1397
Joined: 20 Feb 2007, 01:10

Re: default widget put your building in wait when you E-stall

Post by very_bad_soldier »

Works fine for me. I am using the attached widget. Please test if it works for you too so I can replace the BA one.
Fun fact: The widget has the exact same name and same description but different authors.
Attachments
unit_dgun_unstall.lua
(6.91 KiB) Downloaded 124 times
User avatar
jamerlan
Balanced Annihilation Developer
Posts: 683
Joined: 20 Oct 2009, 13:04

Re: default widget put your building in wait when you E-stall

Post by jamerlan »

very_bad_soldier wrote:Works fine for me. I am using the attached widget. Please test if it works for you too so I can replace the BA one.
Fun fact: The widget has the exact same name and same description but different authors.
Widget that comes with BA is modified version of widget you attached. Actually BA version of widget should be better. For example, in your version functions like "Spring.GetPlayerInfo(MyTeamId)" are not cached like "local GetPlayerInfo = Spring.GetPlayerInfo".

I tested your version of widget and it does not work at all. (I put your widget in luaui/widgets of my spring so it overrides BA version). It does not set factories on wait.

Looks like your widget uses old API: "if (UD.TEDClass == "COMMANDER") then"
The same in BA widget: "if UnitDefs[unitDefID].canManualFire then"
User avatar
Jazcash
Posts: 5309
Joined: 08 Dec 2007, 17:39

Re: default widget put your building in wait when you E-stall

Post by Jazcash »

This is mine which works fine:

http://pastebin.com/LKFjdiPg
User avatar
very_bad_soldier
Posts: 1397
Joined: 20 Feb 2007, 01:10

Re: default widget put your building in wait when you E-stall

Post by very_bad_soldier »

Oops yeah sorry, I confused myself. I meant to post the one Jazcash posted, thats the one that works for me. Actually it is buggy too but better than nothing...
User avatar
Forboding Angel
Evolution RTS Developer
Posts: 14673
Joined: 17 Nov 2005, 02:43

Re: default widget put your building in wait when you E-stall

Post by Forboding Angel »

Run a quick diff on them: http://www.quickdiff.com/
User avatar
Johannes
Posts: 1265
Joined: 17 Sep 2010, 15:49

Re: default widget put your building in wait when you E-stall

Post by Johannes »

very_bad_soldier wrote:Oops yeah sorry, I confused myself. I meant to post the one Jazcash posted, thats the one that works for me. Actually it is buggy too but better than nothing...
I think I'll still prefer nothing...

And put nanos in a ctrl group and it's trivial to wait them anytime.
User avatar
Beherith
Posts: 5145
Joined: 26 Oct 2007, 16:21

Re: default widget put your building in wait when you E-stall

Post by Beherith »

Nanos default to passive, and by the time you have lots of nanos, dgun estall is usually not an issue. It is mostly an issue during early game, when energy production and storage are low.
User avatar
jamerlan
Balanced Annihilation Developer
Posts: 683
Joined: 20 Oct 2009, 13:04

Re: default widget put your building in wait when you E-stall

Post by jamerlan »

Looks like last author of current BA implementation is BrainDamage (author = "BD"). I think we need his opinion. Maybe current implementation is better and bug is easy to fix.

My knowlage of lua and spring lua api are not good. So I can't appraise which implementation is better. Working is better then broken ofc, but BD version can has better realization.
User avatar
very_bad_soldier
Posts: 1397
Joined: 20 Feb 2007, 01:10

Re: default widget put your building in wait when you E-stall

Post by very_bad_soldier »

Johannes wrote:
very_bad_soldier wrote:Oops yeah sorry, I confused myself. I meant to post the one Jazcash posted, thats the one that works for me. Actually it is buggy too but better than nothing...
I think I'll still prefer nothing...

And put nanos in a ctrl group and it's trivial to wait them anytime.
Trivial? Means 3 extra keypresses in an already micro-critical situation. But of course you are free to just not activate widgets you dont like.
And what Behe said, often nanos are not the problem anyway.
User avatar
Johannes
Posts: 1265
Joined: 17 Sep 2010, 15:49

Re: default widget put your building in wait when you E-stall

Post by Johannes »

[number] -> w, what 3rd key are you thinking of?

Well, I wish I could properly group the lab without fucking up the groupings of the units it makes though.
User avatar
very_bad_soldier
Posts: 1397
Joined: 20 Feb 2007, 01:10

Re: default widget put your building in wait when you E-stall

Post by very_bad_soldier »

Johannes wrote:[number] -> w, what 3rd key are you thinking of?
Switching back to com?
User avatar
albator
Posts: 866
Joined: 14 Jan 2009, 14:20

Re: default widget put your building in wait when you E-stall

Post by albator »

imo, just remove the widget that does not work, no need to make all building go on wait. That is confusing and make player reclaiming factory to play is annoying
User avatar
jamerlan
Balanced Annihilation Developer
Posts: 683
Joined: 20 Oct 2009, 13:04

Re: default widget put your building in wait when you E-stall

Post by jamerlan »

albator wrote:imo, just remove the widget that does not work, no need to make all building go on wait. That is confusing and make player reclaiming factory to play is annoying
Then "pro" players will use such widgets and dgun while noobs will just estall and loose.
User avatar
albator
Posts: 866
Joined: 14 Jan 2009, 14:20

Re: default widget put your building in wait when you E-stall

Post by albator »

jamerlan wrote:
albator wrote:imo, just remove the widget that does not work, no need to make all building go on wait. That is confusing and make player reclaiming factory to play is annoying
Then "pro" players will use such widgets and dgun while noobs will just estall and loose.
"PRO player" dont need autostall Dgun widget.

And better that than having player raging cause nothing is building anymore

Imo, before caring of pro/noob, better caring of game working properly
User avatar
jamerlan
Balanced Annihilation Developer
Posts: 683
Joined: 20 Oct 2009, 13:04

Re: default widget put your building in wait when you E-stall

Post by jamerlan »

albator wrote:Imo, before caring of pro/noob, better caring of game working properly
Sure it will be fixed in next version! And thank you for reporting this! But we need to find best solution.
Post Reply

Return to “Balanced Annihilation”