View topic - Release: Spring 84.0! The DragonSlayer!



All times are UTC + 1 hour


Post new topic Reply to topic  [ 88 posts ]  Go to page Previous  1, 2, 3, 4, 5
Author Message
PostPosted: 08 Dec 2011, 02:08 
User avatar

Joined: 14 Jan 2009, 14:20
Kloot wrote:
Quote:
For the third, I can upload replay if needed


You should never assume that giving extra information is not needed, so please do (if it is important to you that this gets fixed for 85.0).


Where do you guys upload replays since knorke ban the guy that was hosting them ?


Top
 Offline Profile  
 
PostPosted: 08 Dec 2011, 02:41 
Content Developer
User avatar

Joined: 13 Jan 2005, 00:46
Location: ModalitÃ
how big is the zipped replay?


Top
 Offline Profile  
 
PostPosted: 08 Dec 2011, 03:03 
Spring Developer

Joined: 08 Oct 2006, 15:58
http://springrts.com/mantis/my_view_page.php

But the issue has already been found and nuked, as well as the second from your list.


Top
 Offline Profile  
 
PostPosted: 08 Dec 2011, 03:52 
Moderator
User avatar

Joined: 22 Feb 2006, 01:02
Location: cheap kitchen
albator wrote:
Where do you guys upload replays since knorke ban the guy that was hosting them ?
not sure if serious. I did not ban Trademark.
I unbanned him after someone else banned him because I felt he should not have been banned.

Anyway, for bugreports it is possible to attach files to mantis posts or forum.


Top
 Offline Profile  
 
PostPosted: 09 Dec 2011, 02:24 

Joined: 20 Feb 2010, 12:17
knorke wrote:
cannon color change might be this commit:
https://github.com/spring/spring/commit/1fe54ba1efe8a5617e245c04053dab325e6078a8#rts/Sim/Weapons/WeaponDefHandler.cpp
Seems like default color is now 1.0f, 0.5f, 0.0f but strangely seems like it was that before too?
Anyway, now projectiles are orange instead of yellow. (guess: old color was 1,1,0)

Hm, in 0.82.7.1 I had this for a cannon weapon:
rgbColor = [[0.8 0.95 0.8]],
gave a bright, almost white projectile with a tint of green.
In 84.0 the same weapon is orange and I can not get it to be a different color at all.

So this reads the colors:
visuals.color = wdTable.GetFloat3("rgbColor", rgbcol);
visuals.color2 = wdTable.GetFloat3("rgbColor2", float3(1.0f, 1.0f, 1.0f));

But then in the next 2 lines the colors that were just read, get overwritten with orange?
if (wd.type == "Cannon") { visuals.color = float3(1.0f, 0.5f, 0.0f); }
if (wd.type == "EmgCannon") { visuals.color = float3(0.9f, 0.9f, 0.2f); }


edit:
armflash, armstump, armbrtha in BA7.60 shot orange projectiles too. (used to be yellowish)

edit2:
seems like bug to me, so mantis: http://springrts.com/mantis/view.php?id=2751


change from yellow to orange might be tolerable in some mods, but others might use different colors (blue, green, red) and intensity (brighter is stronger) to represent different types of weapons and dmg potential. Those few lines of code screw this totally.

ok so bug was fixed. How long until the next release?

(btw, great work devs!)


Top
 Offline Profile  
 
PostPosted: 19 Dec 2011, 11:41 
User avatar

Joined: 07 Feb 2005, 21:30
Location: Cheese factory
Who's idea was it to skip a version number?


Top
 Offline Profile  
 
PostPosted: 19 Dec 2011, 12:05 
Spring Developer
User avatar

Joined: 22 Sep 2007, 08:51
Cheesecan, please stop spamming the whole forum.


Top
 Offline Profile  
 
PostPosted: 19 Dec 2011, 14:43 
Content Developer
User avatar

Joined: 13 Jan 2005, 00:46
Location: ModalitÃ
Cheesecan wrote:
Who's idea was it to skip a version number?

go read threads.. there is much discussion. you can go find it yourself.


Top
 Offline Profile  
 
Display posts from previous:  Sort by  
Post new topic Reply to topic  [ 88 posts ]  Go to page Previous  1, 2, 3, 4, 5

All times are UTC + 1 hour


Who is online

Users browsing this forum: No registered users and 1 guest


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
Jump to:  
Powered by phpBB® Forum Software © phpBB Group

Site layout created by Roflcopter et al.