Dynamic sky

[zerver]

I found that the DynamicSky setting for Advanced sky had been hardcoded to false. I fixed this, but Imbaczek noticed that it uses some CPU.

Most people don't see the sky while playing, so it is a shame to waste CPU on it for no reason.
Do you guys think it would be OK to only update the dynamic sky if it is currently in camera view?

[dizekat]

I found that the DynamicSky setting for Advanced sky had been hardcoded to false. I fixed this, but Imbaczek noticed that it uses some CPU.

Most people don't see the sky while playing, so it is a shame to waste CPU on it for no reason.
Do you guys think it would be OK to only update the dynamic sky if it is currently in camera view?

yes i think so. Though it still must be off-able, as i dont want dynamic sky at all, not even when i see the sky.

[jK]

How do you want to detect if the sky is visible?
Also dynamic sky is very important with large reflective areas and reflective water renderers.

[imbaczek]

just make it so it costs 10% of my framerate and not 80%...

[zerver]

How do you want to detect if the sky is visible?
Also dynamic sky is very important with large reflective areas and reflective water renderers.

Good point ! I guess we will have to update it then. I already reduced the update frequency to once every 10 frames - will reduce further if needed.

yes i think so. Though it still must be off-able, as i dont want dynamic sky at all, not even when i see the sky.

It is off by default and offable, either by registry or console /dynamicsky 0

[imbaczek]

/dynamicsky 1 still makes my spring go from 200fps to 40fps (r6554.)

[Warlord Zsinj]

It is also an option through the Spring Settings function.

I do hope, though, that Spring is not running the dynamic sky behind a mapper-set skybox.