View topic - Engine Testing - 16. January 2012 (85.0.1-53-g9b6cffe)


All times are UTC + 1 hour


Post new topic Reply to topic  [ 18 posts ] 
Author Message
PostPosted: 16 Jan 2012, 22:51 
Spring Developer

Joined: 31 May 2009, 23:08
we are preparing the 86.0 release (mostly a bugfix release).

some of the changes:

* add unitsync python (sub-)module ( https://github.com/spring/pyunitsync )
* fix mismatched feature colvol matrices
* fix two heap-corruption bugs
* [MT] Fix desync
* fix demotool compile #2913
* fix unused hotkeys blocking further ones in the queue
* BeamLasers could hit but not damage units using per-piece colvols
* fix stacktrace in log is cut of
* IsolationMode: use ENV{SPRING_DATADIR} & config's SpringData: before even windows used $HOME syntax, now it uses correct %HOME% windows syntax!
* use OS functions to replace EnvVars in datadir paths: before even windows used $HOME syntax, now it uses correct %HOME% windows syntax!
* fix Intel GPU detection
* Config: add support for a new optional safemodeValue, which is used when spring is started with --safemode (note config values still override it, only defaults change)

full changelog

See the Testing Release Wiki pagefor general info about how to obtain the release, and an archive of all testing releases since the last stable one.

Bugs and issues
Report in this thread or on Mantis.
Remember to attach infolog.txt as file, if you crash!


Last edited by abma on 17 Jan 2012, 00:46, edited 1 time in total.
Top
 Offline Profile  
 
PostPosted: 17 Jan 2012, 00:37 
Server Owner & Developer
User avatar

Joined: 19 May 2006, 18:13
Location: Brno, Czech rep., EU, Terra, Sol, Orion arm, Milky way, Virgo supercluster
What does this mean
"use OS functions to replace EnvVars in datadir paths:"

Does SpringData in env still work on windows?
Top
 Offline Profile  
 
PostPosted: 17 Jan 2012, 00:47 
Spring Developer

Joined: 31 May 2009, 23:08
"use OS functions to replace EnvVars in datadir paths (+ logic change!)

important logic change: before even windows used $HOME syntax, now it uses correct %HOME% windows syntax!"

Quote:
Does SpringData in env still work on windows?


i don't know, i didn't test/change it.
Top
 Offline Profile  
 
PostPosted: 17 Jan 2012, 11:52 
Moderator

Joined: 05 Aug 2009, 19:42
The Windows and non-Windows syntaxes are really just batch and *sh syntaxes, right?
Btw, why is isolation mode using ENV variables - isn't the whole point of isolation mode to have (portable) installs which are separate from system wide installs?
I do recall reading it was causing problems for people, but I'm not sure I understand if this is supposed to fix it or not.
Top
 Offline Profile  
 
PostPosted: 17 Jan 2012, 12:03 
Spring Developer
User avatar

Joined: 28 Jun 2007, 06:30
gajop wrote:
The Windows and non-Windows syntaxes are really just batch and *sh syntaxes, right?
see msdn's ExpandEnvironmentStrings and manpage of wordexp (those are used now)

gajop wrote:
Btw, why is isolation mode using ENV variables - isn't the whole point of isolation mode to have (portable) installs which are separate from system wide installs?
Those vars are user/packager defined, don't artificially limit their usage when there is no need to. The idea behind IsolatedMode is it to separate game installs. It is _not_ to limit Spring to a single folder, which would limit the usage of the mode to never used case. Extending IsolatedMode to multiple (user!!!) IncludeDirs opens the usage of the mode for multiversion engine installs and much more
Top
 Online Profile  
 
PostPosted: 17 Jan 2012, 12:14 
Lobby Developer
User avatar

Joined: 14 Aug 2007, 15:15
gajop wrote:
It is _not_ to limit Spring to a single folder, which would limit the usage of the mode to never used case
Only if you ignore my comments, but that's not really important.
I however I agree with https://github.com/spring/spring/commit ... ent-867729
Top
 Offline Profile  
 
PostPosted: 17 Jan 2012, 12:22 
Moderator

Joined: 05 Aug 2009, 19:42
Imo, isolated mode shouldn't be looking at any global variables, but it could be configured to use outside maps/mods folders in it's .springrc. I think that's what most content/lobby devs are trying to point out.
Not sure if you can use .springrc or something similar to set runtime ENV variables, or if you'd need/want that, but I guess that would also be acceptable.
So what's the current state regarding that? Is it still looking in the globally defined variables (stuff in windows environment settings, /etc/profile ~/.bashrc and whatnot) or not?
Top
 Offline Profile  
 
PostPosted: 17 Jan 2012, 17:40 
User avatar

Joined: 22 Feb 2006, 01:02
Location: cheap kitchen
I downloaded spring_{develop}85.0.1-53-g9b6cffe_minimal-portable.7z
spring.exe crashed when I click lobby or springsettings in the menu:
Image
(happens in 85.0 too: http://springrts.com/mantis/view.php?id=2887)
infolog still seems incomplete...
http://pastebin.com/2nDWcUeT
Funnily "start the lobby" actually launched a springlobby v0.120
Appearently it found
C:\Dokumente und Einstellungen\TP\Eigene Dateien\My Games\Spring\engine\0.82.7\springlobby.exe
god knows what game install/downloader/lobby created a spring install there.
Deleting the whole folder and it no longer crashes and no lobby starts.


Quote:
* fix two heap-corruption bugs
* fix unused hotkeys blocking further ones in the queue
if that refers to placing buildings and transporters, those seem fixed which is very nice. (tested building and loading/unloading transports for 60min game time at high speed and did not crash)
unitgroups work too.
Top
 Offline Profile  
 
PostPosted: 18 Jan 2012, 09:05 
Evolution RTS Developer
User avatar

Joined: 17 Nov 2005, 02:43
jK wrote:
gajop wrote:
The Windows and non-Windows syntaxes are really just batch and *sh syntaxes, right?
see msdn's ExpandEnvironmentStrings and manpage of wordexp (those are used now)

gajop wrote:
Btw, why is isolation mode using ENV variables - isn't the whole point of isolation mode to have (portable) installs which are separate from system wide installs?
Those vars are user/packager defined, don't artificially limit their usage when there is no need to. The idea behind IsolatedMode is it to separate game installs. It is _not_ to limit Spring to a single folder, which would limit the usage of the mode to never used case. Extending IsolatedMode to multiple (user!!!) IncludeDirs opens the usage of the mode for multiversion engine installs and much more


Okiedoke...

So how do I use it? Currently I :
SET SPRING_ISOLATED=1

What do I need to do now to end up with what I had before (Spring locked to it's current directory)?
Top
 Offline Profile  
 
PostPosted: 18 Jan 2012, 10:48 
Moderator

Joined: 12 Oct 2007, 08:24
Is the exact version 85.0.1-53-g9b6cffe particularly important? I just test with the latest version but if there is a good reason I'll test this one.
Top
 Offline Profile  
 
PostPosted: 18 Jan 2012, 11:20 
Server Owner & Developer
User avatar

Joined: 19 May 2006, 18:13
Location: Brno, Czech rep., EU, Terra, Sol, Orion arm, Milky way, Virgo supercluster
Isolated mode needs to look at env variables for those reason:

1) In multiengine scenario, data folder is not within engine folder. Even if its portable, tree structure differs (ZKL puts engines into engine folder in portable folder root)

2) there is no way to tell unitsync folder except for environment variable (which it ignores atm due to some bug ;-)

3) if you start older version of spring or dedicated with the isolated commandline parameters, it ends because it does not know them.

Env variables dont have to be global, ZKL sets them only for the process, they dont change anything user or global bound.
Top
 Offline Profile  
 
PostPosted: 18 Jan 2012, 11:58 
Moderator

Joined: 05 Aug 2009, 19:42
Licho wrote:
Env variables dont have to be global, ZKL sets them only for the process, they dont change anything user or global bound.

Rather, env variables must not be global if spring is run in isolated mode.
Top
 Offline Profile  
 
PostPosted: 18 Jan 2012, 13:15 
Evolution RTS Developer
User avatar

Joined: 17 Nov 2005, 02:43
You can use setx to make them global, but in all honestly, that would potentially cause huge problems for any other spring game install (mitigated by the fact that you could unset those vars easily using the same method for setting them).

Someone answer my question!
Top
 Offline Profile  
 
PostPosted: 21 Jan 2012, 00:03 
Spring Developer

Joined: 31 May 2009, 23:08
@Forb:

this is how it should work:
https://github.com/spring/spring/blob/d ... ater.h#L28

so
"SET SPRING_ISOLATED=1"

should be still fine... (jk, please correct me if not)
Top
 Offline Profile  
 
PostPosted: 21 Jan 2012, 00:13 
Spring Developer

Joined: 31 May 2009, 23:08
@knorke:

can you please retry with >= 85.0.1-64-g33e8343 if the logfiles are still cut of on crash?
Top
 Offline Profile  
 
PostPosted: 21 Jan 2012, 00:17 
User avatar

Joined: 22 Feb 2006, 01:02
Location: cheap kitchen
that link is 404. should it be that specific version or simply newest?
eg http://springrts.com/dl/buildbot/default/develop/85.0.1-63-g5070e2f/spring_%7bdevelop%7d85.0.1-63-g5070e2f_minimal-portable.7z
Top
 Offline Profile  
 
PostPosted: 21 Jan 2012, 07:58 
Spring Developer

Joined: 31 May 2009, 23:08
knorke wrote:
that link is 404.[/url]


i posted before the buildslave has build + uploaded... (now it isn't 404 any more)

you posted ~0:17, upload was at ~0:19... so.. doh! my plan didn't work, you were to fast.

so please try again :)
Top
 Offline Profile  
 
PostPosted: 01 Feb 2012, 15:02 
Spring Developer

Joined: 31 May 2009, 23:08
next testing release: viewtopic.php?f=12&t=27582&p=512903
Top
 Offline Profile  
 
Display posts from previous:  Sort by  
Post new topic Reply to topic  [ 18 posts ] 

All times are UTC + 1 hour


Who is online

Users browsing this forum: No registered users and 1 guest


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
Jump to:  
Powered by phpBB® Forum Software © phpBB Group
Site layout created by Roflcopter et al.