| View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||
|---|---|---|---|---|---|---|---|---|---|
| 0004457 | Spring engine | General | public | 2014-06-26 09:56 | 2014-06-26 22:18 | ||||
| Reporter | Google_Frog | ||||||||
| Assigned To | Kloot | ||||||||
| Priority | normal | Severity | major | Reproducibility | always | ||||
| Status | resolved | Resolution | fixed | ||||||
| Product Version | 97.0.1+git | ||||||||
| Target Version | Fixed in Version | ||||||||
| Summary | 0004457: 97.0.1-45 Bombers do not turn when their target is within maximun weapon range | ||||||||
| Description | In 97.0.1-43 bombers would always turn to face their target. Even if they had started their bombing run they would continue to turn to face their target. This is the desired behaviour. In 97.0.1-45 bombers do not turn if their target is within their maximum weapon range. This is shown very clearly by Pheonix with mini-laser (bomberlaser) and it is also demonstrated by Thunderbird (armstiletto_laser) by looking at the pattern of the ground scars. | ||||||||
| Additional Information | Map: Comet Catcher Redux Game: Zero-K test-7388-c181d9e Relevant change: https://github.com/spring/spring/commit/0361f97881dcf9a54d24564e7be10fffb0225e8e | ||||||||
| Tags | No tags attached. | ||||||||
| Checked infolog.txt for Errors | |||||||||
| Attached Files |
| ||||||||
 Relationships |
|
 Relationships |
| Notes |
|
|
Kloot (developer) 2014-06-26 12:59 |
nothing in that commit refers to weapon range --> your hypothesis is wrong |
|
cleanrock (reporter) 2014-06-26 13:27 |
Kloot, Try this urself, its very obvious that the bomberlaser do not turn when in range. Also, u did a small logic change in ur "compile" commit after 0361f97. If you dont even try to compile your changes its impossible you test em properly. |
|
Google_Frog (reporter) 2014-06-26 13:29 |
Well there is also this change: https://github.com/spring/spring/commit/ffef527e06da28f060d2bfbe65905a748dd2a847 It seems minor. I said a few things in this ticket so what exactly is my hypothesis which is wrong? |
|
Rafal99 (reporter) 2014-06-26 18:26 Last edited: 2014-06-26 21:13 |
From the quick look at: https://github.com/spring/spring/commit/ffef527e06da28f060d2bfbe65905a748dd2a847 The order of conditions got changed, it is: UpdateFlying(wantedHeight, 1.0f) && !goalInFront while before the change it was equal to: !goalInFront && UpdateFlying(wantedHeight, 1.0f) UpdateFlying modifies a lot of stuff so it seems like order of conditions does matter here. |
|
Kloot (developer) 2014-06-26 22:17 |
None of that is relevant. I would appreciate it if people uninvolved with an issue stayed in their caves. "what exactly is my hypothesis which is wrong" Your "bombers do not turn IF..." ASSUMES a relation to weapon range. cleanrock: use "you", "your", and "them" like an adult or don't address me. |
| Notes |
| Issue History |
|||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2014-06-26 09:56 | Google_Frog | New Issue | |
| 2014-06-26 09:56 | Google_Frog | File Added: 20140626_174634_Comet Catcher Redux_97.0.1-43-gcf9dd70 develop.sdf | |
| 2014-06-26 09:57 | Google_Frog | File Added: 20140626_174915_Comet Catcher Redux_97.0.1-45-gffef527 develop.sdf | |
| 2014-06-26 12:59 | Kloot | Note Added: 0013359 | |
| 2014-06-26 13:27 | cleanrock | Note Added: 0013361 | |
| 2014-06-26 13:29 | Google_Frog | Note Added: 0013362 | |
| 2014-06-26 18:26 | Rafal99 | Note Added: 0013367 | |
| 2014-06-26 21:13 | Rafal99 | Note Edited: 0013367 | View Revisions |
| 2014-06-26 22:17 | Kloot | Note Added: 0013368 | |
| 2014-06-26 22:18 | Kloot | Changeset attached | => spring develop 55e6230c |
| 2014-06-26 22:18 | Kloot | Assigned To | => Kloot |
| 2014-06-26 22:18 | Kloot | Status | new => resolved |
| 2014-06-26 22:18 | Kloot | Resolution | open => fixed |
| Issue History |