2024-04-25 07:43 CEST

View Issue Details Jump to Notes ]
IDProjectCategoryView StatusLast Update
0004293Spring engineGeneralpublic2014-02-17 22:32
ReporterJools 
Assigned TojK 
PrioritynormalSeverityminorReproducibilityalways
StatusresolvedResolutionfixed 
Product Version96.0.1+git 
Target Version97.0Fixed in Version 
Summary0004293: F11 doesn't close widget selector
DescriptionIn 96.0.1-199 F11 only opens widget selector, it doesn't close it. In 96.0.1 F11 does both.
Steps To ReproducePress F11 in game, then do it again.
TagsNo tags attached.
Checked infolog.txt for Errors
Attached Files

-Relationships
+Relationships

-Notes

~0012762

abma (administrator)

FYI: ESC closes it (but still a bug)

~0012768

jK (developer)

A bit more complicated issue caused by SDL2 switch.
Much lua uses the crappy keysym.lua which contains hardcoded values, but those changed between SDL1->SDL2 and so all those are incorrect now ...

~0012769

silentwings (reporter)

Is there a way to identify particular keys in lua without checking against hardcoded values?

~0012770

jK (developer)

ohhh great and SDL2 failed again ...

Yes there is a way to check keys w/o hardcoded values, BUT SDL2 bit-or's all SDLK_... with a (1<<30), making them not fit in a float (!), to identify ScanCodes vs. KeyCodes.
So the integer given to the keyboard events are all incorrect atm ... I could vomit when I think of SDL ...

~0012771

Jools (reporter)

F11 was just the first key I noticed. Maybe this report should be renamed to something more general. Same with the key that changes factory build orientation, it doesn't work. For me it's the key left of enter, but I guess it varies with keyboard.

~0012841

abma (administrator)

Last edited: 2014-02-17 03:16

View 3 revisions

@jk:

can this be workarrounded? how to fix this bug? (didn't investigate, but it seems you did)

+Notes

-Issue History
Date Modified Username Field Change
2014-01-24 21:16 Jools New Issue
2014-01-25 15:36 abma Note Added: 0012762
2014-01-25 15:36 abma Target Version => 97.0
2014-01-26 09:29 jK Note Added: 0012768
2014-01-27 01:45 silentwings Note Added: 0012769
2014-01-27 06:23 jK Note Added: 0012770
2014-01-27 21:51 Jools Note Added: 0012771
2014-02-17 03:14 abma Note Added: 0012841
2014-02-17 03:16 abma Note Edited: 0012841 View Revisions
2014-02-17 03:16 abma Note Edited: 0012841 View Revisions
2014-02-17 22:32 jK Changeset attached => spring develop 269aa8bf
2014-02-17 22:32 jK Assigned To => jK
2014-02-17 22:32 jK Status new => resolved
2014-02-17 22:32 jK Resolution open => fixed
+Issue History