View Issue Details

IDProjectCategoryView StatusLast Update
0003084Spring enginepublic2013-04-08 02:33
ReporterTom Fyuri Assigned Tozerver  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionunable to reproduce 
Product Version88.0 
Summary0003084: lua widget in zero-k works different in MT than expected, zero-k
DescriptionIn zero-k there is widget "Chili Core Selector" it provides Ctrl+C hotkey to select commander unit.
But in MT it works a bit different than expected (as in ST).
Every time you press Ctrl+C, it feels like function SelectComm() runs (repeat) forever all the time. Commander is always selected and camera is always focused at commander. Playing like that is next to impossible, because you can never deselect commander nor move camera away.

Widget code: http://code.google.com/searchframe#_IaQsP4Z6YI/trunk/mods/zk/LuaUI/Widgets/gui_chili_core_selector.lua
Additional InformationIn single thread spring version this bug doesn't happen.
I'm not sure what I additional information I should provide next.
TagsNo tags attached.
Checked infolog.txt for Errors

Activities

Tom Fyuri

2012-05-09 20:34

reporter   ~0008675

Last edited: 2012-05-10 22:22

I just had a 10vs10 game in zero-k and after I received commander and factory from afk player. After he got his stuff back (no longer afk). I still could see his stuff at my selections bar.

It seems some lua stuff is handled incorrectly.

EDIT: voting widget don't work after some time in a game (in the beginning it works), later if you press "Yes"/"No" nothing happens. (though you can vote by using chat).

zerver

2012-06-16 16:10

reporter   ~0008792

I could not reproduce the Ctrl+C weirdness, tell me how you do it. What is the (minimum of) widgets you need to have active to make it happen? When I press Ctrl+C nothing happens, and when I press the widget button to select comm, it is selected as it should without hang/repeat.

The selection bar weirdness should be fixed by this
https://github.com/spring/spring/commit/3b7de2b41f05159fbca213a9000120c057670eda

For the voting widget, maybe some part of Chili crashed. The situation is that games do not automatically work 100% with Spring MT. Some changes will usually be required. There is an article here http://springrts.com/wiki/Spring_Multithreaded_Lua

After 89.0 has been released, maybe you could suggest to the ZK dev team to do some testing, tweak it a bit for MT, and implement LuaThreadingModel 4? (BA is using that now)

Tom Fyuri

2012-06-19 17:17

reporter   ~0008803

Regarding ctrl+c try to check if your binding in ZK works. uikeys should have something like "bind c selectcomm" or something like that as far as I remember.

zerver

2013-04-08 02:33

reporter   ~0010406

/bind Ctrl+C selectcomm in console
now comm selects as it should, but the hang does not reproduce (Spring MT 94.11)
possibly already fixed

Issue History

Date Modified Username Field Change
2012-05-08 19:55 Tom Fyuri New Issue
2012-05-09 20:34 Tom Fyuri Note Added: 0008675
2012-05-10 18:36 abma Category General => Spring MT
2012-05-10 22:22 Tom Fyuri Note Edited: 0008675
2012-06-08 21:22 zerver Status new => assigned
2012-06-08 21:22 zerver Assigned To => zerver
2012-06-16 16:10 zerver Note Added: 0008792
2012-06-16 16:10 zerver Status assigned => feedback
2012-06-19 17:17 Tom Fyuri Note Added: 0008803
2013-04-08 02:33 zerver Note Added: 0010406
2013-04-08 02:33 zerver Status feedback => closed
2013-04-08 02:33 zerver Resolution open => unable to reproduce
2014-01-16 16:06 abma Category Spring MT => (No Category)